Skip to content

Conversation

jiajunye
Copy link
Contributor

No description provided.

Signed-off-by: jiajunye <jiajunye@google.com>
Signed-off-by: jiajunye <jiajunye@google.com>
oschaaf
oschaaf previously approved these changes Sep 23, 2020
Copy link
Member

@oschaaf oschaaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one nit, otherwise LGTM

Signed-off-by: jiajunye <jiajunye@google.com>
oschaaf
oschaaf previously approved these changes Sep 24, 2020
@mum4k mum4k added the waiting-for-changes A PR waiting for comments to be resolved and changes to be applied. label Sep 24, 2020
Signed-off-by: jiajunye <jiajunye@google.com>
Signed-off-by: jiajunye <jiajunye@google.com>
Copy link
Collaborator

@mum4k mum4k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one nit.

Signed-off-by: jiajunye <jiajunye@google.com>
Signed-off-by: jiajunye <jiajunye@google.com>
@jiajunye jiajunye added waiting-for-review A PR waiting for a review. and removed waiting-for-changes A PR waiting for comments to be resolved and changes to be applied. labels Oct 2, 2020
@mum4k mum4k merged commit 61996df into envoyproxy:master Oct 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting-for-review A PR waiting for a review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants