Use GitHub mirror for V8 sources #39499
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yan Avlasov <yavlasov@google.com>
|
CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to |
agrawroh
reviewed
May 16, 2025
Comment on lines
+1170
to
+1174
| sha256 = "6fb91b839e9c36ca4c151268f772e7a6a888a75bcb947f37be9758e49f485db7", | ||
| urls = ["https://github.com/v8/v8/archive/refs/tags/{version}.tar.gz"], | ||
| use_category = ["dataplane_ext"], | ||
| extensions = ["envoy.wasm.runtime.v8"], | ||
| release_date = "2022-10-12", | ||
| release_date = "2022-09-28", |
There was a problem hiding this comment.
@yanavlasov The SHA and the date changes are expected?
There was a problem hiding this comment.
Yes. The archives were created differently and on different dates so the checksum and date differences are expected.
|
/lgtm deps |
PeterL328
pushed a commit
to PeterL328/envoy
that referenced
this pull request
May 16, 2025
This just updates V8 repository leaving currently used tag the same to create baseline. V8 tag update in the followup PR. Risk Level: Low Testing: Unit Tests Docs Changes: N/A Release Notes: N/A Platform Specific Features: N/A --------- Signed-off-by: Yan Avlasov <yavlasov@google.com> Signed-off-by: Peter Leng <yleng@pinterest.com>
fishpan1209
pushed a commit
to fishpan1209/envoy
that referenced
this pull request
May 22, 2025
This just updates V8 repository leaving currently used tag the same to create baseline. V8 tag update in the followup PR. Risk Level: Low Testing: Unit Tests Docs Changes: N/A Release Notes: N/A Platform Specific Features: N/A --------- Signed-off-by: Yan Avlasov <yavlasov@google.com> Signed-off-by: Ting Pan <panting@google.com>
phlax
pushed a commit
to phlax/envoy
that referenced
this pull request
Jul 23, 2025
This just updates V8 repository leaving currently used tag the same to create baseline. V8 tag update in the followup PR. Risk Level: Low Testing: Unit Tests Docs Changes: N/A Release Notes: N/A Platform Specific Features: N/A --------- Signed-off-by: Yan Avlasov <yavlasov@google.com>
phlax
pushed a commit
to phlax/envoy
that referenced
this pull request
Jul 23, 2025
This just updates V8 repository leaving currently used tag the same to create baseline. V8 tag update in the followup PR. Risk Level: Low Testing: Unit Tests Docs Changes: N/A Release Notes: N/A Platform Specific Features: N/A --------- Signed-off-by: Yan Avlasov <yavlasov@google.com> Signed-off-by: Ryan Northey <ryan@synca.io>
phlax
pushed a commit
to phlax/envoy
that referenced
this pull request
Jul 23, 2025
This just updates V8 repository leaving currently used tag the same to create baseline. V8 tag update in the followup PR. Risk Level: Low Testing: Unit Tests Docs Changes: N/A Release Notes: N/A Platform Specific Features: N/A --------- Signed-off-by: Yan Avlasov <yavlasov@google.com> Signed-off-by: Ryan Northey <ryan@synca.io>
phlax
pushed a commit
to phlax/envoy
that referenced
this pull request
Jul 23, 2025
This just updates V8 repository leaving currently used tag the same to create baseline. V8 tag update in the followup PR. Risk Level: Low Testing: Unit Tests Docs Changes: N/A Release Notes: N/A Platform Specific Features: N/A --------- Signed-off-by: Yan Avlasov <yavlasov@google.com> Signed-off-by: Ryan Northey <ryan@synca.io>
phlax
pushed a commit
that referenced
this pull request
Jul 23, 2025
This just updates V8 repository leaving currently used tag the same to create baseline. V8 tag update in the followup PR. Risk Level: Low Testing: Unit Tests Docs Changes: N/A Release Notes: N/A Platform Specific Features: N/A --------- Signed-off-by: Yan Avlasov <yavlasov@google.com> Signed-off-by: Ryan Northey <ryan@synca.io>
phlax
pushed a commit
that referenced
this pull request
Jul 23, 2025
This just updates V8 repository leaving currently used tag the same to create baseline. V8 tag update in the followup PR. Risk Level: Low Testing: Unit Tests Docs Changes: N/A Release Notes: N/A Platform Specific Features: N/A --------- Signed-off-by: Yan Avlasov <yavlasov@google.com> Signed-off-by: Ryan Northey <ryan@synca.io>
phlax
pushed a commit
that referenced
this pull request
Jul 23, 2025
This just updates V8 repository leaving currently used tag the same to create baseline. V8 tag update in the followup PR. Risk Level: Low Testing: Unit Tests Docs Changes: N/A Release Notes: N/A Platform Specific Features: N/A --------- Signed-off-by: Yan Avlasov <yavlasov@google.com> Signed-off-by: Ryan Northey <ryan@synca.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional Description:
This just updates V8 repository leaving currently used tag the same to create baseline. V8 tag update in the followup PR.
Risk Level: Low
Testing: Unit Tests
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: N/A