cluster manager: gracefully handle static/cds cluster manager init #387
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change refactors CM init so that we can properly do initialization across static clusters as well as CDS clusters. The normal init flow looks like this: 1) Initialize static primary clusters 2) Initialize static secondary clusters 3) Start CDS fetch 4) Initialize CDS primary clusters 5) Initialize CDS secondary clusters This should now work correectly if any of the phases are absent or immediately complete (as in the case of static clusters). fixes #367 fixes #330
|
@lyft/network-team |
RomanDzhabarov
approved these changes
Jan 27, 2017
PiotrSikora
pushed a commit
to PiotrSikora/envoy
that referenced
this pull request
Feb 21, 2020
Cache and share the base Wasm. Use the new definition of Wasm Key to find the base Wasm and thread local Wasm. Signed-off-by: John Plevyak <jplevyak@gmail.com>
bianpengyuan
pushed a commit
to istio/envoy
that referenced
this pull request
Feb 22, 2020
* Cache and share the base Wasm (envoyproxy#387) Cache and share the base Wasm. Use the new definition of Wasm Key to find the base Wasm and thread local Wasm. Signed-off-by: John Plevyak <jplevyak@gmail.com> * Only call proxy_on_vm_start() when the VM is actaully starting. (envoyproxy#400) Signed-off-by: John Plevyak <jplevyak@gmail.com> * Fix SEGV when reusing the base vm. (envoyproxy#413) Signed-off-by: John Plevyak <jplevyak@gmail.com> Co-authored-by: John Plevyak <jplevyak@gmail.com>
PiotrSikora
pushed a commit
to istio/envoy
that referenced
this pull request
Feb 24, 2020
* Cache and share the base Wasm. Use the new definition of Wasm Key to find the base Wasm and thread local Wasm. Signed-off-by: John Plevyak <jplevyak@gmail.com>
wolfguoliang
pushed a commit
to wolfguoliang/envoy
that referenced
this pull request
Jan 23, 2021
kyessenov
pushed a commit
to kyessenov/envoy
that referenced
this pull request
Sep 10, 2021
* Cache and share the base Wasm. Use the new definition of Wasm Key to find the base Wasm and thread local Wasm. Signed-off-by: John Plevyak <jplevyak@gmail.com>
jpsim
pushed a commit
that referenced
this pull request
Nov 28, 2022
Signed-off-by: Mike Schore <mike.schore@gmail.com> Signed-off-by: JP Simard <jp@jpsim.com>
jpsim
pushed a commit
that referenced
this pull request
Nov 29, 2022
Signed-off-by: Mike Schore <mike.schore@gmail.com> Signed-off-by: JP Simard <jp@jpsim.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change refactors CM init so that we can properly do initialization
across static clusters as well as CDS clusters. The normal init flow
looks like this:
This should now work correectly if any of the phases are absent or
immediately complete (as in the case of static clusters).
fixes #367
fixes #330