ssl: remove openssl threading code if using boringssl #382
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boringssl has internal support for threading.
|
@lyft/network-team @PiotrSikora |
|
Both: However, if you want to remove dead code, then |
|
I just noticed it in the coverage build so just deleting dead code. I will fix it up to include the other functions you mention. |
|
@PiotrSikora updated |
RomanDzhabarov
approved these changes
Jan 27, 2017
rshriram
pushed a commit
to rshriram/envoy
that referenced
this pull request
Oct 30, 2018
- Remvoe transcoding filter, which is already available at https://lyft.github.io/envoy/docs/configuration/http_filters/grpc_json_transcoder_filter.html
PiotrSikora
added a commit
to istio/envoy
that referenced
this pull request
Jan 25, 2020
We don't care about it, and it's currently broken. Signed-off-by: Piotr Sikora <piotrsikora@google.com>
PiotrSikora
added a commit
to PiotrSikora/envoy
that referenced
this pull request
Feb 24, 2020
We don't care about it, and it's currently broken. Signed-off-by: Piotr Sikora <piotrsikora@google.com>
PiotrSikora
added a commit
to istio/envoy
that referenced
this pull request
Feb 24, 2020
…161) We don't care about it, and it's currently broken. Signed-off-by: Piotr Sikora <piotrsikora@google.com>
wolfguoliang
pushed a commit
to wolfguoliang/envoy
that referenced
this pull request
Jan 23, 2021
zh-translation:docs/root/configuration/other_features/other_features.rst
jpsim
pushed a commit
that referenced
this pull request
Nov 28, 2022
envoyproxy/envoy-mobile#381 surfaced an issue where extensions aren't allowed on Swift protocols that are visible to Objective-C. This meant that the Swift `Client` protocol (conformed to by the `Envoy` Swift class) could not provide a default implementation of the non-streaming `send` function, and the function had to be moved into the concrete `Envoy` class so that it could be visible from both Swift and Objective-C. This ended up breaking our Swift tests in `ClientTests.swift` (as mentioned in that PR's description). In order to fix these tests, we need to convert `EnvoyHTTPStream` into a protocol and use an `EnvoyHTTPStreamImpl` concrete type - similarly to how we do with `EnvoyEngine`/`EnvoyEngineImpl`. This PR updates the types accordingly, and fixes the tests. Also renames the tests to `EnvoyTests` rather than `ClientTests` since this is testing the concrete type. Signed-off-by: Michael Rebello <me@michaelrebello.com> Signed-off-by: JP Simard <jp@jpsim.com>
jpsim
pushed a commit
that referenced
this pull request
Nov 29, 2022
envoyproxy/envoy-mobile#381 surfaced an issue where extensions aren't allowed on Swift protocols that are visible to Objective-C. This meant that the Swift `Client` protocol (conformed to by the `Envoy` Swift class) could not provide a default implementation of the non-streaming `send` function, and the function had to be moved into the concrete `Envoy` class so that it could be visible from both Swift and Objective-C. This ended up breaking our Swift tests in `ClientTests.swift` (as mentioned in that PR's description). In order to fix these tests, we need to convert `EnvoyHTTPStream` into a protocol and use an `EnvoyHTTPStreamImpl` concrete type - similarly to how we do with `EnvoyEngine`/`EnvoyEngineImpl`. This PR updates the types accordingly, and fixes the tests. Also renames the tests to `EnvoyTests` rather than `ClientTests` since this is testing the concrete type. Signed-off-by: Michael Rebello <me@michaelrebello.com> Signed-off-by: JP Simard <jp@jpsim.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
boringssl has internal support for threading.