Skip to content

pipe: no exceptions #34708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 18, 2024
Merged

pipe: no exceptions #34708

merged 1 commit into from
Jun 18, 2024

Conversation

alyssawilk
Copy link
Contributor

@alyssawilk alyssawilk commented Jun 12, 2024 •
edited
Loading

Risk Level: low
Testing: updated tests
Docs Changes: n/a
Release Notes: n/a
envoyproxy/envoy-mobile#176

@repokitteh-read-only RepoKitteh - Read Only
Copy link

As a reminder, PRs marked as draft will not be automatically assigned reviewers,
or be handled by maintainer-oncall triage.

Please mark your PR as ready when you want it to be reviewed!

🐱

Caused by: #34708 was opened by alyssawilk.

see: more, trace.

@alyssawilk alyssawilk force-pushed the pipe branch 4 times, most recently from 2c96486 to ce426de Compare June 12, 2024 18:01
@alyssawilk
pipe: no exceptions
24d7345 
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
@alyssawilk alyssawilk marked this pull request as ready for review June 17, 2024 15:46
@alyssawilk
Copy link
Contributor Author

/retest

@alyssawilk alyssawilk merged commit c36922c into envoyproxy:main Jun 18, 2024
Nealsoni00 pushed a commit to Nealsoni00/envoy that referenced this pull request Jun 18, 2024
@alyssawilk @Nealsoni00
pipe: no exceptions (envoyproxy#34708)
e3328f4 
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Signed-off-by: Neal Soni <Nealsoni00@gmail.com>
antoniovleonti pushed a commit to antoniovleonti/envoy that referenced this pull request Jun 26, 2024
@alyssawilk @antoniovleonti
pipe: no exceptions (envoyproxy#34708)
2d94138 
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Signed-off-by: antoniovleonti <leonti@google.com>
@alyssawilk alyssawilk deleted the pipe branch October 9, 2024 19:53
sayboras added a commit to cilium/proxy that referenced this pull request Oct 31, 2024
@sayboras
Adjust cilium custom filters
aa3f716 
Relates: envoyproxy/envoy#34708
Relates: envoyproxy/envoy#34761
Relates: envoyproxy/envoy#34437
Relates: envoyproxy/envoy#34012

Signed-off-by: Tam Mach <tam.mach@cilium.io>
sayboras added a commit to cilium/proxy that referenced this pull request Nov 13, 2024
@sayboras
Adjust cilium custom filters
6248ece 
Relates: envoyproxy/envoy#34708
Relates: envoyproxy/envoy#34761
Relates: envoyproxy/envoy#34437
Relates: envoyproxy/envoy#34012

Signed-off-by: Tam Mach <tam.mach@cilium.io>
sayboras added a commit to cilium/proxy that referenced this pull request Nov 13, 2024
@sayboras
Adjust cilium custom filters
490f84a 
Relates: envoyproxy/envoy#34708
Relates: envoyproxy/envoy#34761
Relates: envoyproxy/envoy#34437
Relates: envoyproxy/envoy#34012

Signed-off-by: Tam Mach <tam.mach@cilium.io>
sayboras added a commit to cilium/proxy that referenced this pull request Nov 13, 2024
@sayboras
Adjust cilium custom filters
e11149d 
Relates: envoyproxy/envoy#34708
Relates: envoyproxy/envoy#34761
Relates: envoyproxy/envoy#34437
Relates: envoyproxy/envoy#34012

Signed-off-by: Tam Mach <tam.mach@cilium.io>
sayboras added a commit to cilium/proxy that referenced this pull request Nov 13, 2024
@sayboras
Adjust cilium custom filters
b6c41a5 
Relates: envoyproxy/envoy#34708
Relates: envoyproxy/envoy#34761
Relates: envoyproxy/envoy#34437
Relates: envoyproxy/envoy#34012

Signed-off-by: Tam Mach <tam.mach@cilium.io>
sayboras added a commit to cilium/proxy that referenced this pull request Nov 14, 2024
@sayboras
Adjust cilium custom filters
b31c9a9 
Relates: envoyproxy/envoy#34708
Relates: envoyproxy/envoy#34761
Relates: envoyproxy/envoy#34437
Relates: envoyproxy/envoy#34012

Signed-off-by: Tam Mach <tam.mach@cilium.io>
sayboras added a commit to cilium/proxy that referenced this pull request Nov 14, 2024
@sayboras
Adjust cilium custom filters
17ebaa7 
Relates: envoyproxy/envoy#34708
Relates: envoyproxy/envoy#34761
Relates: envoyproxy/envoy#34437
Relates: envoyproxy/envoy#34012

Signed-off-by: Tam Mach <tam.mach@cilium.io>
github-merge-queue bot pushed a commit to cilium/proxy that referenced this pull request Nov 15, 2024
@sayboras @jrajahalme
Adjust cilium custom filters
98e4fbe 
Relates: envoyproxy/envoy#34708
Relates: envoyproxy/envoy#34761
Relates: envoyproxy/envoy#34437
Relates: envoyproxy/envoy#34012

Signed-off-by: Tam Mach <tam.mach@cilium.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zuercher zuercher zuercher approved these changes

@kyessenov kyessenov Awaiting requested review from kyessenov kyessenov is a code owner

@mattklein123 mattklein123 Awaiting requested review from mattklein123 mattklein123 is a code owner

@tyxia tyxia Awaiting requested review from tyxia tyxia is a code owner

@ggreenway ggreenway Awaiting requested review from ggreenway ggreenway is a code owner

@wbpcode wbpcode Awaiting requested review from wbpcode wbpcode is a code owner

@yanavlasov yanavlasov Awaiting requested review from yanavlasov yanavlasov is a code owner

@htuch htuch Awaiting requested review from htuch

Assignees

@zuercher zuercher

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alyssawilk @zuercher