callback manager: exception free #34012
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dc70721 to
0bb23a0
Compare
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
0bb23a0 to
5d25e16
Compare
There was a problem hiding this comment.
Looks great. I'm surprised though. I expected to see some code which previous did throw SomeException now doing return absl::SomeStatus. But I don't think I see any of those. It looks like we always return OkStatus(), which makes me think we could continue just returning void.... which makes me think I've misunderstood something in this PR. Can you correct my misunderstanding?
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
|
yeah for clarity this is expected to be no-op change. |
RyanTheOptimist
approved these changes
May 8, 2024
sayboras
added a commit
to cilium/proxy
that referenced
this pull request
Oct 31, 2024
Relates: envoyproxy/envoy#34708 Relates: envoyproxy/envoy#34761 Relates: envoyproxy/envoy#34437 Relates: envoyproxy/envoy#34012 Signed-off-by: Tam Mach <tam.mach@cilium.io>
sayboras
added a commit
to cilium/proxy
that referenced
this pull request
Nov 13, 2024
Relates: envoyproxy/envoy#34708 Relates: envoyproxy/envoy#34761 Relates: envoyproxy/envoy#34437 Relates: envoyproxy/envoy#34012 Signed-off-by: Tam Mach <tam.mach@cilium.io>
sayboras
added a commit
to cilium/proxy
that referenced
this pull request
Nov 13, 2024
Relates: envoyproxy/envoy#34708 Relates: envoyproxy/envoy#34761 Relates: envoyproxy/envoy#34437 Relates: envoyproxy/envoy#34012 Signed-off-by: Tam Mach <tam.mach@cilium.io>
sayboras
added a commit
to cilium/proxy
that referenced
this pull request
Nov 13, 2024
Relates: envoyproxy/envoy#34708 Relates: envoyproxy/envoy#34761 Relates: envoyproxy/envoy#34437 Relates: envoyproxy/envoy#34012 Signed-off-by: Tam Mach <tam.mach@cilium.io>
sayboras
added a commit
to cilium/proxy
that referenced
this pull request
Nov 13, 2024
Relates: envoyproxy/envoy#34708 Relates: envoyproxy/envoy#34761 Relates: envoyproxy/envoy#34437 Relates: envoyproxy/envoy#34012 Signed-off-by: Tam Mach <tam.mach@cilium.io>
sayboras
added a commit
to cilium/proxy
that referenced
this pull request
Nov 14, 2024
Relates: envoyproxy/envoy#34708 Relates: envoyproxy/envoy#34761 Relates: envoyproxy/envoy#34437 Relates: envoyproxy/envoy#34012 Signed-off-by: Tam Mach <tam.mach@cilium.io>
sayboras
added a commit
to cilium/proxy
that referenced
this pull request
Nov 14, 2024
Relates: envoyproxy/envoy#34708 Relates: envoyproxy/envoy#34761 Relates: envoyproxy/envoy#34437 Relates: envoyproxy/envoy#34012 Signed-off-by: Tam Mach <tam.mach@cilium.io>
github-merge-queue bot
pushed a commit
to cilium/proxy
that referenced
this pull request
Nov 15, 2024
Relates: envoyproxy/envoy#34708 Relates: envoyproxy/envoy#34761 Relates: envoyproxy/envoy#34437 Relates: envoyproxy/envoy#34012 Signed-off-by: Tam Mach <tam.mach@cilium.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Risk Level: medium
Testing: updated tests
Docs Changes: n/a
Release Notes: n/a
envoyproxy/envoy-mobile#176