Skip to content

Bump io_bazel_rules_go -> 0.46.0 #33084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 19, 2024
Merged

Bump io_bazel_rules_go -> 0.46.0 #33084

merged 3 commits into from
Apr 19, 2024

Conversation

mmorel-35
Copy link
Contributor

@mmorel-35 mmorel-35 commented Mar 23, 2024 •
edited
Loading

Closes #32316

Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

@mmorel-35
Bump io_bazel_rules_go -> 0.46.0
31c7f16 
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
@repokitteh-read-only RepoKitteh - Read Only
Copy link

As a reminder, PRs marked as draft will not be automatically assigned reviewers,
or be handled by maintainer-oncall triage.

Please mark your PR as ready when you want it to be reviewed!

🐱

Caused by: #33084 was opened by mmorel-35.

see: more, trace.

@repokitteh-read-only repokitteh-read-only bot added the deps Approval required for changes to Envoy's external dependencies label Mar 23, 2024
@repokitteh-read-only RepoKitteh - Read Only
Copy link

CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to (bazel/.*repos.*\.bzl)|(bazel/dependency_imports\.bzl)|(api/bazel/.*\.bzl)|(.*/requirements\.txt)|(.*\.patch).
envoyproxy/dependency-shepherds assignee is @mattklein123

🐱

Caused by: #33084 was opened by mmorel-35.

see: more, trace.

@mmorel-35 mmorel-35 mentioned this pull request Mar 23, 2024
Merged
@phlax phlax mentioned this pull request Mar 25, 2024
Closed
@phlax
Copy link
Member

phlax commented Mar 27, 2024

should we land this @mmorel-35 seems to work and would be good to update rules_go - i have a feeling it will also allow some other deps to be updated

@mmorel-35
Copy link
Contributor Author

We need cncf/xds#93 to be merged first.
The commit used here for the test is not to be used as it is from my branch

@mmorel-35
Merge branch 'main' into dependency/bazel/io_bazel_rules_go/0.46.0
047f986 
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
@mmorel-35
Update repository_locations.bzl
d2d1566 
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
@mmorel-35 mmorel-35 marked this pull request as ready for review April 19, 2024 20:08
@mmorel-35
Copy link
Contributor Author

Hi @phlax ,
That's eligible to merge so when this passes the test you can merge it when you feel ready

phlax
phlax approved these changes Apr 19, 2024
View reviewed changes
Copy link
Member

@phlax phlax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for all your hard work on this @mmorel-35 - really appreciated

@repokitteh-read-only repokitteh-read-only bot removed the deps Approval required for changes to Envoy's external dependencies label Apr 19, 2024
@phlax phlax enabled auto-merge (squash) April 19, 2024 20:20
@phlax phlax merged commit af915ef into envoyproxy:main Apr 19, 2024
@mmorel-35 mmorel-35 deleted the dependency/bazel/io_bazel_rules_go/0.46.0 branch April 19, 2024 22:09
cainelli pushed a commit to cainelli/envoy that referenced this pull request Apr 25, 2024
@mmorel-35
Bump io_bazel_rules_go -> 0.46.0 (envoyproxy#33084)
210f8de 
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
alyssawilk pushed a commit to alyssawilk/envoy that referenced this pull request Apr 29, 2024
@mmorel-35 @alyssawilk
Bump io_bazel_rules_go -> 0.46.0 (envoyproxy#33084)
43dbad2 
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phlax phlax phlax approved these changes

Assignees

@mattklein123 mattklein123

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Newer release available io_bazel_rules_go: v0.46.0 (current: v0.39.1)
3 participants
@mmorel-35 @phlax @mattklein123