Skip to content

Conversation

mmorel-35
Copy link
Contributor

Commit Message: Migrate from github.com/golang/protobuf to google.golang.org/protobuf
Additional Description: github.com/golang/protobuf has been superseded by google.golang.org/protobuf
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

@repokitteh-read-only repokitteh-read-only bot added the deps Approval required for changes to Envoy's external dependencies label Mar 21, 2024
Copy link

CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to (bazel/.*repos.*\.bzl)|(bazel/dependency_imports\.bzl)|(api/bazel/.*\.bzl)|(.*/requirements\.txt)|(.*\.patch).
envoyproxy/dependency-shepherds assignee is @mattklein123

🐱

Caused by: #33048 was opened by mmorel-35.

see: more, trace.

@mmorel-35 mmorel-35 marked this pull request as draft March 21, 2024 20:38
@mmorel-35 mmorel-35 force-pushed the protobuf-v2 branch 5 times, most recently from c98ee69 to 5b58b9c Compare March 22, 2024 07:24
@mmorel-35
Copy link
Contributor Author

mmorel-35 commented Mar 22, 2024

Hi @mattklein123 , @phlax ,
I have done several attempt bu each time the old version of go protobuf is expected.
I originally started with a PR in https://github.com/cncf/xds/pull/90/files where the code generation worked well and I have been told to start the change here. But with this failing attemps I start believing that the change shall start in xds and not in here. Am I missing something ?

@phlax
Copy link
Member

phlax commented Mar 22, 2024

But with this failing attemps I start believing that the change shall start in xds and not in here.

not sure exactly how the 3 repos interact, but i think what i would try is to update the dependency version using the commit hash from the xds repo/pr

as i think the go-control-plane repo depends both on xds and envoy repos i would PR there with the updated xds hash, and the hash from the envoy pr (that also includes updated xds)

Copy link
Contributor

@adisuissa adisuissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
@mmorel-35 mmorel-35 marked this pull request as ready for review March 22, 2024 13:42
@repokitteh-read-only repokitteh-read-only bot removed the deps Approval required for changes to Envoy's external dependencies label Mar 22, 2024
@mattklein123 mattklein123 merged commit 1fc31d7 into envoyproxy:main Mar 22, 2024
@mmorel-35 mmorel-35 deleted the protobuf-v2 branch March 22, 2024 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants