Egress support v2 #157
Egress support v2 #157
Conversation
…for egress operations.
| * Http Tracing can be enabled/disabled on a per connection manager basis. | ||
| * Here we specify some specific for connection manager settings. | ||
| */ | ||
| struct TracingConnectionManagerConfig { |
There was a problem hiding this comment.
doesn't need to be in public includes. I don't think TracingType does either.
There was a problem hiding this comment.
right, moving that out.
| @@ -161,7 +161,12 @@ class ConnectionManagerConfig { | |||
| /** | |||
| * @return true if tracing is enabled otherwise it returns false; | |||
| */ | |||
| virtual bool isTracing() PURE; | |||
| virtual bool isTracing(const Http::AccessLog::RequestInfo& request_info) PURE; | |||
There was a problem hiding this comment.
I would rename shouldTraceRequest(...)
| /** | ||
| * TODO: comment. | ||
| */ | ||
| virtual const Optional<Tracing::TracingConnectionManagerConfig>& tracingInfo() PURE; |
There was a problem hiding this comment.
I would rename tracingConfig()
| } | ||
|
|
||
| // This should not happen as switch above covers all cases, this is just to make compiler happy. | ||
| throw EnvoyException("unknown tracing type"); |
There was a problem hiding this comment.
Can you add the tracing_type value to the exception?
There was a problem hiding this comment.
Just use NOT_IMPLEMENTED or something clear that it should not happen
There was a problem hiding this comment.
i'll switch to NOT_IMPLEMENTED here and refine the comment to emphasize that compiler also enforces all types covered by switch above.
| data to the :ref:`configured tracing provider <config_tracing>`. Defaults to false. | ||
| .. _config_http_conn_man_tracing: | ||
|
|
||
| tracing |
There was a problem hiding this comment.
generally a sub-level json object gets its own section (see other docs). Can you make a new section on this page, put the nested json docs there, and link to it from here (again see other docs)
| @@ -6,6 +6,13 @@ | |||
|
|
|||
| namespace Tracing { | |||
|
|
|||
| class TracingContext { | |||
| // Trace all traceable requests. | ||
| All, | ||
| // Trace only when there is an upstream failure reason. | ||
| UpstreamFailureReason |
There was a problem hiding this comment.
I would call this UpstreamFailure
Signed-off-by: Piotr Sikora <piotrsikora@google.com>
* Cache and share the base Wasm (envoyproxy#387) Cache and share the base Wasm. Use the new definition of Wasm Key to find the base Wasm and thread local Wasm. Signed-off-by: John Plevyak <jplevyak@gmail.com> * Only call proxy_on_vm_start() when the VM is actaully starting. (envoyproxy#400) Signed-off-by: John Plevyak <jplevyak@gmail.com> * Fix SEGV when reusing the base vm. (envoyproxy#413) Signed-off-by: John Plevyak <jplevyak@gmail.com> Co-authored-by: John Plevyak <jplevyak@gmail.com>
zh-translation: /intro/arch_overview/other_features/compression/libraries.rst
Signed-off-by: Jose Nino jnino@lyft.com Description: fix small typo Risk Level: low -- fix inline comment typo Signed-off-by: JP Simard <jp@jpsim.com>
Signed-off-by: Jose Nino jnino@lyft.com Description: fix small typo Risk Level: low -- fix inline comment typo Signed-off-by: JP Simard <jp@jpsim.com>
Work is in progress for this item. Need to add tests etc.