Skip to content

Conversation

Shikugawa
Copy link
Member

Signed-off-by: Matt Klein mklein@lyft.com

For an explanation of how to fill out the fields, please see the relevant section
in PULL_REQUESTS.md

Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Deprecated:]
[Optional API Considerations:]

mattklein123 and others added 2 commits February 27, 2021 12:59
Signed-off-by: Matt Klein <mklein@lyft.com>
Signed-off-by: Shikugawa <rei@tetrate.io>
@repokitteh-read-only
Copy link

CC @envoyproxy/api-shepherds: Your approval is needed for changes made to (api/envoy[\w/]*/(v1alpha\d?|v1|v2alpha\d?|v2))|(api/envoy/type/(matcher/)?\w+.proto).
CC @envoyproxy/api-shepherds: Your approval is needed for changes made to api/envoy/.
API shepherd assignee is @htuch
CC @envoyproxy/api-watchers: FYI only for changes made to api/envoy/.

🐱

Caused by: #15221 was opened by Shikugawa.

see: more, trace.

Signed-off-by: Shikugawa <rei@tetrate.io>
@htuch
Copy link
Member

htuch commented Feb 28, 2021

@Shikugawa this makes sense I think for branch maintenance, is the plan to do a point release on this though? Not sure if there is any end user facing change, but I might have missed something.

@Shikugawa
Copy link
Member Author

@htuch Without this patch, we will face failure to generate docs. (and releated envoyproxy org repositories that changed from master -> main) And this PR doesn't have direct effect to enduser, I think. because only to follow change.

Copy link
Member

@htuch htuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@repokitteh-read-only repokitteh-read-only bot removed the api label Mar 1, 2021
@htuch
Copy link
Member

htuch commented Mar 1, 2021

/lgtm v2-freeze

@htuch htuch merged commit d638267 into envoyproxy:release/v1.16 Mar 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants