[fuzz] Added least request load balancer fuzz #13424
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Zach <zasweq@google.com>
Signed-off-by: Zach <zasweq@google.com>
Signed-off-by: Zach <zasweq@google.com>
Signed-off-by: Zach <zasweq@google.com>
Signed-off-by: Zach <zasweq@google.com>
Signed-off-by: Zach <zasweq@google.com>
Signed-off-by: Zach <zasweq@google.com>
Signed-off-by: Zach <zasweq@google.com>
Signed-off-by: Zach <zasweq@google.com>
Signed-off-by: Zach <zasweq@google.com>
Signed-off-by: Zach <zasweq@google.com>
Signed-off-by: Zach <zasweq@google.com>
Signed-off-by: Zach <zasweq@google.com>
Signed-off-by: Zach <zasweq@google.com>
Signed-off-by: Zach <zasweq@google.com>
Signed-off-by: Zach <zasweq@google.com>
Signed-off-by: Zach <zasweq@google.com>
Signed-off-by: Zach <zasweq@google.com>
|
/assign @asraa @adisuissa |
Signed-off-by: Zach <zasweq@google.com>
akonradi
suggested changes
Oct 7, 2020
| uint32_t num_excluded_hosts) { | ||
| MockHostSet& host_set = *priority_set_.getMockHostSet(int(failover_host_set)); | ||
| uint32_t i = 0; | ||
| for (; i < num_healthy_hosts && i < host_set.hosts_.size(); ++i) { |
There was a problem hiding this comment.
Same here, reserve space in host_set.healthy_hosts_ before appending.
htuch
pushed a commit
that referenced
this pull request
Oct 20, 2020
Part of securing Envoy against untrusted upstreams. The high level design of this fuzzer is a base class that handles static host setup/updates, setting up random() calls, and replays the action stream. Then, more specific fuzzers (in this pull request, random), create specific load balancers with all the state they need, pass it into the base class, which then runs checks on it. #13424 also uses this design pattern, except with a least request load balancer, however using the same shared base class. 43.6% line coverage over source/common/upstream/load_balancer_impl.cc, 30ish exec/sec. Risk Level: Low Testing: Added corpus entries that represent unit tests. Signed-off-by: Zach <zasweq@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message: Added least request load balancer fuzz. It uses the same health check fuzz base class as #13400.
Additional Description: 56.6% line coverage over source/common/upstream/load_balancer_impl.cc. Runs at 25 - 30 exec/sec.
Risk Level: Low
Testing:
Docs Changes:
Release Notes: