Skip to content

Conversation

kyessenov
Copy link
Contributor

Signed-off-by: Kuat Yessenov kuat@google.com

Description: populate HTTP codec protocol in outer connection stream info. Replacing overly large #10524 with a simpler change needed to support detection of HTTP in connection access loggers
Risk Level: low
Testing: unit, manual
Docs Changes: none
Release Notes: none

Signed-off-by: Kuat Yessenov <kuat@google.com>
@htuch htuch requested a review from alyssawilk April 3, 2020 00:28
Copy link
Contributor

@alyssawilk alyssawilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, much simpler and cleaner than the last pass, thanks!

@alyssawilk
Copy link
Contributor

Adding one reviewer from prior PR for cross-company review :-)

Copy link
Member

@mattklein123 mattklein123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@mattklein123 mattklein123 merged commit 4c8d83e into envoyproxy:master Apr 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants