coverage: introduce ONLY_EXTRA_QUERY_PATHS #10674
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jose Nino <jnino@lyft.com>
lizan
reviewed
Apr 7, 2020
|
updated @lizan |
lizan
approved these changes
Apr 7, 2020
|
This PR caused some regression when running coverage locally
I believe this line shouldn't be run when $COVERAGE_TARGETS is just //test/... I hit some error here. I don't know why it doesn't get hit in CI when CI also runs with //test/... envoy/test/coverage/gen_build.sh Line 37 in c2a6373 Is that right? @junr03 Edit: disregard, sorry about that! whatever problem is happening with me running local coverage is from sometime after this, but the failure just pointed to something around there. works before the bazel 3.0 bump |
|
@asraa ok, do let me know if you find any problems! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: introduce an environment variable that allows consuming projects to only run coverage over private extensions.
Risk Level: low
Testing: locally with Envoy Mobile as a consuming project. And existing coverage run in CI
Docs Changes: inline comment
Signed-off-by: Jose Nino jnino@lyft.com