Skip to content

event: workaround for https://github.com/libevent/libevent/issues/984. #10666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 6, 2020
Merged

event: workaround for https://github.com/libevent/libevent/issues/984. #10666

merged 1 commit into from
Apr 6, 2020

Conversation

htuch
Copy link
Member

@htuch htuch commented Apr 6, 2020

This is affecting tests, introducing flakes.

Risk level: Low
Testing: CI

Signed-off-by: Harvey Tuch htuch@google.com

@htuch
event: workaround for libevent/libevent#984.
508bc0b 
This is affecting tests, introducing flakes.

Risk level: Low
Testing: CI

Signed-off-by: Harvey Tuch <htuch@google.com>
@htuch htuch requested review from mattklein123 and asraa April 6, 2020 14:09
asraa
asraa approved these changes Apr 6, 2020
View reviewed changes
Copy link
Contributor

@asraa asraa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

For tracking, this is a temporary workaround #8199

mattklein123
mattklein123 approved these changes Apr 6, 2020
View reviewed changes
Copy link
Member

@mattklein123 mattklein123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you.

@mattklein123 mattklein123 self-assigned this Apr 6, 2020
@mattklein123 mattklein123 merged commit cbf513e into envoyproxy:master Apr 6, 2020
@mattklein123 mattklein123 mentioned this pull request Apr 6, 2020
Closed
@htuch htuch deleted the phantom-event-workaround branch April 6, 2020 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattklein123 mattklein123 mattklein123 approved these changes

+1 more reviewer

@asraa asraa asraa approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@asraa asraa

@mattklein123 mattklein123

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@htuch @asraa @mattklein123