Skip to content

docs: correct idle timeout docs #10663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 6, 2020
Merged

docs: correct idle timeout docs #10663

merged 2 commits into from
Apr 6, 2020

Conversation

ramaraochavali
Copy link
Contributor

Description: fixes idle timeout docs
Risk Level: N/A
Testing: N/A
Docs Changes: N/A
Release Notes: N/A

@ramaraochavali
fix idle timeout docs
2b0dbc7 
Signed-off-by: Rama Chavali <rama.rao@salesforce.com>
@ramaraochavali
fix idle timeout docs
4e8548f 
Signed-off-by: Rama Chavali <rama.rao@salesforce.com>
@repokitteh-read-only
Copy link

CC @envoyproxy/api-shepherds: Your approval is needed for changes made to api/.

🐱

Caused by: #10663 was opened by ramaraochavali.

see: more, trace.

asraa
asraa approved these changes Apr 6, 2020
View reviewed changes
Copy link
Contributor

@asraa asraa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for catching that!

Took me a second, so just for reference, seems like there was a gotcha in HCM because of a deprecated workaround but default set here

envoy/source/extensions/filters/network/http_connection_manager/config.cc

Line 227 in 4449939

idle_timeout_ = std::chrono::hours(1);

@mattklein123 mattklein123 merged commit 9e78ab3 into envoyproxy:master Apr 6, 2020
@ramaraochavali ramaraochavali deleted the fix/idle_timeout_docs branch April 6, 2020 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@asraa asraa asraa approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
api
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ramaraochavali @asraa @mattklein123