Skip to content

server: downgrade SIGUSR1 log message into info and clarify #10658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 6, 2020
Merged

server: downgrade SIGUSR1 log message into info and clarify #10658

merged 1 commit into from
Apr 6, 2020

Conversation

mattklein123
Copy link
Member

This shouldn't be a warning as it confuses operators.

Risk Level: Low
Testing: None
Docs Changes: N/A
Release Notes: Added

@mattklein123
server: downgrade SIGUSR1 log message into info and clarify
3230ae1 
This shouldn't be a warning as it confuses operators.

Signed-off-by: Matt Klein <mklein@lyft.com>
asraa
asraa approved these changes Apr 6, 2020
View reviewed changes
Copy link
Contributor

@asraa asraa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for fixing version_history and adding the log statement!

@asraa asraa merged commit 6d678b6 into master Apr 6, 2020
@mattklein123 mattklein123 deleted the change_log_level branch April 8, 2020 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@asraa asraa asraa approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattklein123 @asraa