Skip to content

Conversation

htuch
Copy link
Member

@htuch htuch commented Apr 3, 2020

The HTTP/1 codec implies a connection close following a stream reset of
any kind, including explicit resetStream(). This patch ensures that
codec_impl_fuzz_test completes without any further connection use
following a stream reset.

Fixes oss-fuzz issue
https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=21272.

Risk level: Low
Testing: Corpus entry added.

Signed-off-by: Harvey Tuch htuch@google.com

The HTTP/1 codec implies a connection close following a stream reset of
any kind, including explicit resetStream(). This patch ensures that
codec_impl_fuzz_test completes without any further connection use
following a stream reset.

Fixes oss-fuzz issue
https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=21272.

Risk level: Low
Testing: Corpus entry added.

Signed-off-by: Harvey Tuch <htuch@google.com>
@htuch htuch requested a review from asraa April 3, 2020 20:11
Copy link
Contributor

@asraa asraa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for fixing this! Small question about the usefulness of DebugMode in the class.

Copy link
Contributor

@asraa asraa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, thanks for the clarification. Thank you!

@mattklein123 mattklein123 merged commit ceae3ff into envoyproxy:master Apr 7, 2020
@htuch htuch deleted the header-assert-fuzz branch April 7, 2020 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants