Skip to content

Conversation

derekargueta
Copy link
Member

Description: Fixes misc. cases where the test case begins with a lowercase letter.
Risk Level: low
Testing: existing
Docs Changes: n/a
Release Notes: n/a

Signed-off-by: Derek Argueta darguetap@gmail.com

Signed-off-by: Derek Argueta <darguetap@gmail.com>
Signed-off-by: Derek Argueta <darguetap@gmail.com>
@lizan lizan self-assigned this Feb 20, 2020
@derekargueta derekargueta marked this pull request as ready for review February 20, 2020 23:22
snowp
snowp previously approved these changes Feb 20, 2020
Copy link
Contributor

@snowp snowp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Is this something we could potentially lint for in the future?

@derekargueta
Copy link
Member Author

@snowp yeah should be easy to catch with a regex-based pattern in check_format.py. I used TEST_.\(.*,\s[a-z].*\)\s\{ to find all of these, I'll clean it up a bit and add it to check_format.py

Signed-off-by: Derek Argueta <darguetap@gmail.com>
Signed-off-by: Derek Argueta <darguetap@gmail.com>
@lizan
Copy link
Member

lizan commented Feb 21, 2020

@derekargueta We have TEST() pattern as well.

Signed-off-by: Derek Argueta <darguetap@gmail.com>
@derekargueta
Copy link
Member Author

derekargueta commented Feb 25, 2020

Will fix merge conflict today

Signed-off-by: Derek Argueta <deargueta@tesla.com>
@mattklein123 mattklein123 merged commit c2628ff into envoyproxy:master Mar 3, 2020
@derekargueta derekargueta deleted the dereka/datasource-test-casing branch February 18, 2021 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants