stats: cleanup APIs and avoid extra conversions between StatName and string. #10165
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joshua Marantz <jmarantz@google.com>
Signed-off-by: Joshua Marantz <jmarantz@google.com>
Signed-off-by: Joshua Marantz <jmarantz@google.com>
Signed-off-by: Joshua Marantz <jmarantz@google.com>
Signed-off-by: Joshua Marantz <jmarantz@google.com>
Signed-off-by: Joshua Marantz <jmarantz@google.com>
Signed-off-by: Joshua Marantz <jmarantz@google.com>
…kes. Signed-off-by: Joshua Marantz <jmarantz@google.com>
… to StatName. Signed-off-by: Joshua Marantz <jmarantz@google.com>
snowp
suggested changes
Mar 2, 2020
| void SymbolTableImpl::Encoding::appendToMemBlock(StatName stat_name, | ||
| MemBlockBuilder<uint8_t>& mem_block) { | ||
| const uint8_t* data = stat_name.dataIncludingSize(); | ||
| if (data == nullptr) { |
There was a problem hiding this comment.
what's the use case for appending a stat name with no data? is this just to make it easier in test?
There was a problem hiding this comment.
no, empty constructor for null-stats and for when there is no tag-extracted-name.
This wasn't necessary before because a StatName constructed from "" didn't require this special-casing, but I wanted to allow StatName() to also work; without this it crashes.
| @@ -516,7 +526,9 @@ void StatNameStorageSet::free(SymbolTable& symbol_table) { | |||
| SymbolTable::StoragePtr SymbolTableImpl::join(const StatNameVec& stat_names) const { | |||
| uint64_t num_bytes = 0; | |||
| for (StatName stat_name : stat_names) { | |||
| num_bytes += stat_name.dataSize(); | |||
| if (!stat_name.empty()) { | |||
There was a problem hiding this comment.
There are places in the code where elements being join()ed are empty, and we have been skipping these.
Here though we just have another case of an empty-constructed StatName() will crash now if we don't special-case this.
Signed-off-by: Lizan Zhou <lizan@tetrate.io>
Signed-off-by: Joshua Marantz <jmarantz@google.com>
Signed-off-by: Joshua Marantz <jmarantz@google.com>
Signed-off-by: Joshua Marantz <jmarantz@google.com>
snowp
suggested changes
Mar 4, 2020
| @@ -43,6 +43,13 @@ class MockDecoder : public Decoder { | |||
| MOCK_METHOD(void, onData, (Buffer::Instance & data)); | |||
| }; | |||
|
|
|||
| class TestStatStore : public Stats::SymbolTableProvider, public Stats::IsolatedStoreImpl { | |||
Signed-off-by: Joshua Marantz <jmarantz@google.com>
snowp
approved these changes
Mar 4, 2020
mattklein123
approved these changes
Mar 4, 2020
Signed-off-by: Joshua Marantz <jmarantz@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Now that we take tags as a vector of StatName pairs, change the other args to also pass via StatName. This will reduce redundant converstions between string and StatName and also reduce acquisition of the symbol table lock.
Risk Level: low
Testing: //test/...
Docs Changes: n/a
Release Notes: n/a