[fuzz] fix filter fuzz bugs #10144
Merged
[fuzz] fix filter fuzz bugs #10144
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Asra Ali <asraa@google.com>
|
I think there is already an existing |
Signed-off-by: Asra Ali <asraa@google.com>
Signed-off-by: Asra Ali <asraa@google.com>
Signed-off-by: Asra Ali <asraa@google.com>
yanavlasov
approved these changes
Feb 28, 2020
| @@ -38,7 +38,8 @@ message RateLimit { | |||
| // :ref:`x-envoy-internal<config_http_conn_man_headers_x-envoy-internal>` is not set or false, a | |||
| // request is considered external. The filter defaults to *both*, and it will apply to all request | |||
| // types. | |||
| string request_type = 3; | |||
| string request_type = 3 | |||
There was a problem hiding this comment.
Weird it is not an enum
mattklein123
approved these changes
Mar 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes some config related bugs that came up from the fuzzer.
request_typeinRateLimitproto.Fixes:
https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=20851
https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=20845
https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=20839
Testing: regression corpus entries added
Signed-off-by: Asra Ali asraa@google.com