use new buffers by default #7883
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lizan
previously approved these changes
Aug 12, 2019
|
@securityinsanity sure, the code looks good to me, however I'm not merging this until the security release, to keep the upgrade process smooth. |
|
👍 I agree there, our pipeline just checks for approved PRs before picking. Thanks! |
|
I believe we should be good to merge this now, since 1.11.1 is fully out? |
|
🤞 please merge master. /wait |
|
Can do here in a bit. |
added 2 commits
August 14, 2019 10:57
fixes envoyproxy#7314 this commit changes the default implementation of buffers to the new implementation by default. Signed-off-by: Cynthia Coan <ccoan@instructure.com>
|
Master has been merged, successfully 👍 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
switch Envoy::Buffer to Brian Pane's implementation (aka "new buffers") by default.
Risk Level: Medium
Testing:
Ran through the following test plan locally:
There's also be some testers in actual environments see #7314 , and Envoy Meeting Minutes.
Docs Changes: None
Release Notes: Added a line about how it's the default, including how to turn it off.
fixes #7314