grpc access logger: refactor common gRPC ALS out #7879
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lizan Zhou <lizan@tetrate.io>
Signed-off-by: Lizan Zhou <lizan@tetrate.io>
Signed-off-by: Lizan Zhou <lizan@tetrate.io>
Signed-off-by: Lizan Zhou <lizan@tetrate.io>
|
Note to reviewers: despite of overall large PR, I kept each commit easier to review. |
|
@euroelessar would you be interested in taking a first review pass since you have been working on this code recently? |
euroelessar
reviewed
Aug 9, 2019
| const envoy::config::accesslog::v2::CommonGrpcAccessLogConfig& config) { | ||
| // TODO(euroelessar): Consider cleaning up loggers. | ||
| auto& cache = tls_slot_->getTyped<ThreadLocalCache>(); | ||
| const std::size_t cache_key = MessageUtil::hash(config); |
There was a problem hiding this comment.
With the separation in place key should include a notion if it's http or tcp logger. Otherwise Envoy can not ensure API promise anymore (that each logging stream is always either http or tcp).
There was a problem hiding this comment.
Yes, thanks for the reminder, added a TODO here and will add the types when I implement TCP logger.
mattklein123
approved these changes
Aug 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
In preparation to implement TCP gRPC Access Logger.
Risk Level: Low (refactoring only)
Testing: CI
Docs Changes: N/A
Release Notes: N/A