Skip to content

Conversation

asraa
Copy link
Contributor

@asraa asraa commented Aug 7, 2019

This fuzzer tests our hash utilities. Line coverage from source/common/common/hash.h and hash.cc is 89%.

Risk level: Low
Testing: Starting dummy corpus added.

asraa added 2 commits August 7, 2019 11:42
Signed-off-by: Asra Ali <asraa@google.com>
Signed-off-by: Asra Ali <asraa@google.com>

format

Signed-off-by: Asra Ali <asraa@google.com>
Copy link
Member

@htuch htuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks. One comment before merging.

name = "hash_fuzz_test",
srcs = ["hash_fuzz_test.cc"],
corpus = "hash_corpus",
# Fuzzer is stable, no bugs, simple test target; avoid emitting CO2.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you consider letting it run for some amount of time on ClusterFuzz? What about catching regressions as we bump our version dependency?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could definitely do, I thought about following this PR with some regressions from local bazel/libfuzzer runs since it's relatively low risk, but I'll remove that tag and let it run!

Signed-off-by: Asra Ali <asraa@google.com>
Copy link
Member

@htuch htuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ta

@mattklein123 mattklein123 merged commit 5210894 into envoyproxy:master Aug 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants