Skip to content

Conversation

dnoe
Copy link
Contributor

@dnoe dnoe commented Jul 11, 2019

In #7395, the c-ARES dependency
version number was increased to gain access to a new getaddrinfo API by
importing a specific nonrelease SHA from c-ARES.

This specific SHA did not include
c-ares/c-ares@b949cc3
, made subsequently, which contains important security relevant fixes for the getaddrinfo
API.

This PR bumps the c-ARES version number to include them.

Signed-off-by: Dan Noé dpn@google.com

Description:
Risk Level: Low - external dependency version update
Testing: bazel test //test/...

In envoyproxy#7395, the c-ARES dependency
version number was increased to gain access to a new getaddrinfo API by
importing a specific nonrelease SHA from c-ARES.

This specific SHA did not include
c-ares/c-ares@b949cc3
which contains important security relevant fixes for the getaddrinfo
API.

This PR bumps the c-ARES version number to include them.

Signed-off-by: Dan Noé <dpn@google.com>
Copy link
Contributor

@alyssawilk alyssawilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find, thanks!
LGTM assuming CI is happy

@alyssawilk alyssawilk self-assigned this Jul 11, 2019
@alyssawilk alyssawilk merged commit 3094b9e into envoyproxy:master Jul 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants