api: clarify non-empty LDS/CDS resource hints. #7512
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to better support clients such as gRPC-LB that want to access only a single listener/cluster, provide the scope in the xDS specification to specify explicit resource hints. Signed-off-by: Harvey Tuch <htuch@google.com>
|
CC @envoyproxy/api-shepherds @envoyproxy/udpa-wg @markdroth @vishalpowar |
|
LGTM. Thanks! |
mattklein123
previously approved these changes
Jul 9, 2019
|
Update the discovery.proto ?
|
Signed-off-by: Harvey Tuch <htuch@google.com>
mattklein123
approved these changes
Jul 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to better support clients such as gRPC-LB that want to access
only a single listener/cluster, provide the scope in the xDS
specification to specify explicit resource hints.
Signed-off-by: Harvey Tuch htuch@google.com