docs: fix incorrect doc about cluster warming in CDS #4040
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0c9cd38 to
f04442d
Compare
mattklein123
reviewed
Aug 3, 2018
api/XDS_PROTOCOL.md
Outdated
| RDS if configured. Clusters are warmed when adding/removing/updating | ||
| clusters. On the other hand, routes are not warmed, i.e., the management | ||
| plane must ensure that clusters referenced by a route are in place, before | ||
| pushing the updates for a rotue. |
There was a problem hiding this comment.
As long as you are in here do you mind fixing the "rotue" typo? Thank you!
There was a problem hiding this comment.
I think maybe you forgot to push?
f04442d to
0973440
Compare
0973440 to
c9d35e8
Compare
Signed-off-by: Ruoshan Huang <ruoshan.huang@gmail.com>
|
Sorry for the trouble :( , fixed for real this time ;p |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For an explanation of how to fill out the fields, please see the relevant section
in PULL_REQUESTS.md
Description: doc update
Risk Level: low
Testing:
Docs Changes: api/XDS_PROTOCOL.md
Release Notes:
[Optional Fixes #Issue]
[Optional Deprecated:]