deps: update gRPC to 1.14.0 #4047
Conversation
Signed-off-by: Lizan Zhou <zlizan@google.com>
|
@lizan the CI tests fail, seems to be related to deps and |
Signed-off-by: Lizan Zhou <zlizan@google.com>
bazel/repositories.bzl
Outdated
| @@ -484,7 +484,20 @@ def _com_google_protobuf(): | |||
| def _com_github_grpc_grpc(): | |||
| _repository_impl("com_github_grpc_grpc") | |||
|
|
|||
| if "com_github_nanopb_nanopb" not in native.existing_rules(): | |||
There was a problem hiding this comment.
@htuch This is the reason for the previous CI error. I agree it looks kind of hacky but seems to be the best way to include it in Envoy today. Loading @com_google_grpc_grpc//bazel:grpc_deps.bzl and call grpc_deps() won't work at all in current structure we have in this file. Any better suggestion?
There was a problem hiding this comment.
If this is a gRPC C core hard dependency, we can add it as an external dep, sure. We do this for other gRPC deps below, e.g. cares.
bazel/repositories.bzl
Outdated
| native.new_http_archive( | ||
| name = "com_github_nanopb_nanopb", | ||
| build_file = "@com_github_grpc_grpc//third_party:nanopb.BUILD", | ||
| strip_prefix = "nanopb-f8ac463766281625ad710900479130c7fcb4d63b", |
There was a problem hiding this comment.
should we move SHA into repository_locations.bzl?
bazel/repositories.bzl
Outdated
| @@ -484,7 +484,20 @@ def _com_google_protobuf(): | |||
| def _com_github_grpc_grpc(): | |||
| _repository_impl("com_github_grpc_grpc") | |||
|
|
|||
| if "com_github_nanopb_nanopb" not in native.existing_rules(): | |||
There was a problem hiding this comment.
If this is a gRPC C core hard dependency, we can add it as an external dep, sure. We do this for other gRPC deps below, e.g. cares.
bazel/repositories.bzl
Outdated
| native.new_http_archive( | ||
| name = "com_github_nanopb_nanopb", | ||
| build_file = "@com_github_grpc_grpc//third_party:nanopb.BUILD", | ||
| strip_prefix = "nanopb-f8ac463766281625ad710900479130c7fcb4d63b", |
Signed-off-by: Lizan Zhou <zlizan@google.com>
|
LGTM |
Signed-off-by: Lizan Zhou zlizan@google.com
Description:
Pick up latest gRPC 1.14 for partially local credentials support, and keep update with latest stable generally.
Risk Level: Low
Testing: CI
Docs Changes: N/A
Release Notes: N/A