add cluster metadata to a route #598
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yuval Kohavi <yuval.kohavi@gmail.com>
mattklein123
reviewed
Apr 3, 2018
envoy/api/v2/route/route.proto
Outdated
| // For instance, if the metadata is intended for the Router filter, | ||
| // the filter name should be specified as *envoy.router*. | ||
| // | ||
| // On runtime, this object will a merged with the cluster_metadata from the enclosing |
There was a problem hiding this comment.
nit: please ref link to the enclosing "cluster_metadata" field.
Signed-off-by: Yuval Kohavi <yuval.kohavi@gmail.com>
mattklein123
approved these changes
Apr 3, 2018
|
Sounds good, thank you! |
|
LGTM with one question: does it make sense to treat this as cluster metadata or route metadata? |
|
its a bit of both - its the metadata of the cluster chosen for routing. specifically it's useful in the case of traffic splitting where you don't know in advance which cluster will be chosen. |
|
OK, seems legit. I had originally envisaged having all the metadata that factors into a particular route or cluster selection being merged anyway prior to hitting logging/stats. That didn't end up happening, but this would fit that model if we do go there some day. |
htuch
approved these changes
Apr 3, 2018
This was referenced Apr 4, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per envoyproxy/envoy#2851, adding metadata object to the specific routed cluster. envoy patch is ready and a PR for envoy will be created when this PR is merged (so I can update the repository_locations.bzl)