[release/v1.2] chore: fix gen (#5166) #5273
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix gen Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com> (cherry picked from commit 34db8af) Signed-off-by: Arko Dasgupta <arko@tetrate.io>
guydc
reviewed
Feb 13, 2025
| @@ -0,0 +1,147 @@ | |||
| clientTrafficPolicies: | |||
There was a problem hiding this comment.
Do we need to add this test file?
as long as it passes tests, I guess that there's no harm...
There was a problem hiding this comment.
tests pass, lets keep it ?
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/v1.2 #5273 +/- ##
================================================
+ Coverage 65.80% 65.86% +0.06%
================================================
Files 211 211
Lines 32072 32072
================================================
+ Hits 21105 21125 +20
+ Misses 9714 9698 -16
+ Partials 1253 1249 -4 ☔ View full report in Codecov by Sentry. |
guydc
approved these changes
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix gen
(cherry picked from commit 34db8af)