Skip to content

Conversation

zhaohuabing
Copy link
Member

docs for: #5011

@zhaohuabing zhaohuabing requested a review from a team as a code owner January 17, 2025 08:23
@zhaohuabing zhaohuabing requested review from a team and removed request for a team January 17, 2025 08:34
Copy link

codecov bot commented Jan 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.88%. Comparing base (549fdde) to head (11e4b80).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5085      +/-   ##
==========================================
+ Coverage   66.86%   66.88%   +0.02%     
==========================================
  Files         210      210              
  Lines       32979    32979              
==========================================
+ Hits        22052    22059       +7     
+ Misses       9588     9584       -4     
+ Partials     1339     1336       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhaohuabing zhaohuabing changed the title Docs: how to specify a self-signed ca for the remote jwks host in the SP JWT settings. docs: how to specify a self-signed ca for the remote jwks host in the SP JWT settings. Jan 17, 2025
@arkodg arkodg added this to the v1.3.0 milestone Jan 21, 2025
@arkodg
Copy link
Contributor

arkodg commented Jan 24, 2025

hey @zhaohuabing the files are empty here 😕

@zhaohuabing
Copy link
Member Author

hey @zhaohuabing the files are empty here 😕

Updated, I modified the docs in the wrong directory and the changes have been overwritten by the make gen-check. :-)

Copy link
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks !

Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>
Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>
Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>
@zhaohuabing zhaohuabing merged commit fdc7849 into envoyproxy:main Jan 27, 2025
28 checks passed
zhaohuabing added a commit to zhaohuabing/gateway that referenced this pull request Jan 27, 2025
… SP JWT settings. (envoyproxy#5085)

* docs for jwt self-signed ca

Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>

* fix gen

Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>

* update docs

Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>

---------

Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>
zhaohuabing added a commit to zhaohuabing/gateway that referenced this pull request Jan 27, 2025
… SP JWT settings. (envoyproxy#5085)

* docs for jwt self-signed ca

Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>

* fix gen

Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>

* update docs

Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>

---------

Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>
zhaohuabing added a commit to zhaohuabing/gateway that referenced this pull request Jan 27, 2025
… SP JWT settings. (envoyproxy#5085)

* docs for jwt self-signed ca

Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>

* fix gen

Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>

* update docs

Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>

---------

Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>
guydc pushed a commit to guydc/gateway that referenced this pull request Jan 31, 2025
… SP JWT settings. (envoyproxy#5085)

* docs for jwt self-signed ca

Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>

* fix gen

Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>

* update docs

Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>

---------

Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>
guydc pushed a commit to guydc/gateway that referenced this pull request Jan 31, 2025
… SP JWT settings. (envoyproxy#5085)

* docs for jwt self-signed ca

Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>

* fix gen

Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>

* update docs

Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>

---------

Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>
guydc pushed a commit to guydc/gateway that referenced this pull request Jan 31, 2025
… SP JWT settings. (envoyproxy#5085)

* docs for jwt self-signed ca

Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>

* fix gen

Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>

* update docs

Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>

---------

Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>
guydc pushed a commit to guydc/gateway that referenced this pull request Jan 31, 2025
… SP JWT settings. (envoyproxy#5085)

* docs for jwt self-signed ca

Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>

* fix gen

Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>

* update docs

Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>

---------

Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>
(cherry picked from commit fdc7849)
Signed-off-by: Guy Daich <guy.daich@sap.com>
guydc pushed a commit to guydc/gateway that referenced this pull request Jan 31, 2025
… SP JWT settings. (envoyproxy#5085)

* docs for jwt self-signed ca

Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>

* fix gen

Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>

* update docs

Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>

---------

Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>
(cherry picked from commit fdc7849)
Signed-off-by: Guy Daich <guy.daich@sap.com>
guydc pushed a commit to guydc/gateway that referenced this pull request Jan 31, 2025
… SP JWT settings. (envoyproxy#5085)

* docs for jwt self-signed ca

Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>

* fix gen

Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>

* update docs

Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>

---------

Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>
(cherry picked from commit fdc7849)
Signed-off-by: Guy Daich <guy.daich@sap.com>
guydc added a commit that referenced this pull request Jan 31, 2025
* doc: response compression (#5071)

compression docs

Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>
(cherry picked from commit 549fdde)
Signed-off-by: Guy Daich <guy.daich@sap.com>

* docs: how to specify a self-signed ca for the remote jwks host in the SP JWT settings. (#5085)

* docs for jwt self-signed ca

Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>

* fix gen

Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>

* update docs

Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>

---------

Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>
(cherry picked from commit fdc7849)
Signed-off-by: Guy Daich <guy.daich@sap.com>

* chore: fix gen (#5166)

fix gen

Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>
(cherry picked from commit 34db8af)
Signed-off-by: Guy Daich <guy.daich@sap.com>

* docs: add api key auth instructions (#5097)

* docs: add api key auth instruction

Signed-off-by: Taufik Mulyana <nothinux@gmail.com>

* fix: remove unrelated links

Signed-off-by: Taufik Mulyana <nothinux@gmail.com>

---------

Signed-off-by: Taufik Mulyana <nothinux@gmail.com>
(cherry picked from commit b5cf087)
Signed-off-by: Guy Daich <guy.daich@sap.com>

* add SECURITY.md (#5167)

Signed-off-by: Arko Dasgupta <arko@tetrate.io>
(cherry picked from commit f7a10eb)
Signed-off-by: Guy Daich <guy.daich@sap.com>

* chore: link SECURITY.md (#5168)

Signed-off-by: Arko Dasgupta <arko@tetrate.io>
(cherry picked from commit ac9026f)
Signed-off-by: Guy Daich <guy.daich@sap.com>

* build(deps): bump actions/stale from 9.0.0 to 9.1.0 (#5162)

Bumps [actions/stale](https://github.com/actions/stale) from 9.0.0 to 9.1.0.
- [Release notes](https://github.com/actions/stale/releases)
- [Changelog](https://github.com/actions/stale/blob/main/CHANGELOG.md)
- [Commits](actions/stale@28ca103...5bef64f)

---
updated-dependencies:
- dependency-name: actions/stale
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Arko Dasgupta <arkodg@users.noreply.github.com>
(cherry picked from commit 57d4aa8)
Signed-off-by: Guy Daich <guy.daich@sap.com>

* docs: rm sectionName from some of the examples (#5173)

adds whats left off from #4868

deleted the sectionName in these examples because the Service spec does
not define a port `Name`

Signed-off-by: Arko Dasgupta <arko@tetrate.io>
(cherry picked from commit 45804e2)
Signed-off-by: Guy Daich <guy.daich@sap.com>

* ci(fix): osv-scanner PR mode (#5174)

fix: osv-scanner PR mode

Signed-off-by: shahar-h <shahar.harari@sap.com>
Co-authored-by: Guy Daich <guy.daich@sap.com>
(cherry picked from commit e904d3f)
Signed-off-by: Guy Daich <guy.daich@sap.com>

* wip: docs: add standalone in container instruction (#5172)

* docs: add standalone in container instruction

Signed-off-by: Denis Shatokhin <d_shatokhin@outlook.com>

* docs: update headings and image tag

Signed-off-by: Denis Shatokhin <d_shatokhin@outlook.com>

---------

Signed-off-by: Denis Shatokhin <d_shatokhin@outlook.com>
(cherry picked from commit a3448c1)
Signed-off-by: Guy Daich <guy.daich@sap.com>

* docs: update prerequisites files with installation and connectivity t… (#5094)

* docs: update prerequisites files with installation and connectivity testing steps

Signed-off-by: DeeBi9 <deepanshudb1@gmail.com>

* lint

Signed-off-by: DeeBi9 <deepanshudb1@gmail.com>

* docs: remove the Note

Signed-off-by: DeeBi9 <deepanshudb1@gmail.com>

* remove redundant code

Signed-off-by: DeeBi9 <deepanshudb1@gmail.com>

---------

Signed-off-by: DeeBi9 <deepanshudb1@gmail.com>
(cherry picked from commit 3253339)
Signed-off-by: Guy Daich <guy.daich@sap.com>

* [release/v1.3] fix 1.3.0-rc.1 release note (#5175)

* fix 1.3.0-rc.1 release note

Signed-off-by: Guy Daich <guy.daich@sap.com>

* more fixes

Signed-off-by: Guy Daich <guy.daich@sap.com>

---------

Signed-off-by: Guy Daich <guy.daich@sap.com>
(cherry picked from commit 4fba2bf)
Signed-off-by: Guy Daich <guy.daich@sap.com>

* fail validation if baseInterval is 0s (#5176)

* fail validation if baseInterval is 0s

Fixes: #5147

Signed-off-by: Arko Dasgupta <arko@tetrate.io>

* more validations

Signed-off-by: Arko Dasgupta <arko@tetrate.io>

---------

Signed-off-by: Arko Dasgupta <arko@tetrate.io>
(cherry picked from commit 4844d9a)
Signed-off-by: Guy Daich <guy.daich@sap.com>

* [release/1.3] release notes (#5177)

Signed-off-by: Guy Daich <guy.daich@sap.com>
(cherry picked from commit c2215b2)
Signed-off-by: Guy Daich <guy.daich@sap.com>

---------

Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>
Signed-off-by: Guy Daich <guy.daich@sap.com>
Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>
Signed-off-by: Taufik Mulyana <nothinux@gmail.com>
Signed-off-by: Arko Dasgupta <arko@tetrate.io>
Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: shahar-h <shahar.harari@sap.com>
Signed-off-by: Denis Shatokhin <d_shatokhin@outlook.com>
Signed-off-by: DeeBi9 <deepanshudb1@gmail.com>
Co-authored-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>
Co-authored-by: Taufik Mulyana <17433202+nothinux@users.noreply.github.com>
Co-authored-by: Arko Dasgupta <arkodg@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: shahar-h <shahar.harari@sap.com>
Co-authored-by: Denis Shatokhin <d_shatokhin@outlook.com>
Co-authored-by: Deepanshu Bisht <113498676+DeeBi9@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants