docs: update BackendTLSPolicy docs #4868
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4868 +/- ##
==========================================
- Coverage 66.31% 66.29% -0.02%
==========================================
Files 209 209
Lines 31956 31956
==========================================
- Hits 21191 21186 -5
- Misses 9518 9522 +4
- Partials 1247 1248 +1 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>
b306d6a to
416293c
Compare
arkodg
approved these changes
Dec 9, 2024
arkodg
approved these changes
Dec 9, 2024
|
This broke our setup when upgraded. Could we please update the release notes to highlight it as a breaking change? Just so that others not run into this causing downtime for their services. |
|
are you using v0.0.0-latest @lsjostro ? this hasn't released yet https://github.com/envoyproxy/gateway/pull/4784/files |
|
Nope, the feature/fix was released with v1.2.4. (maybe not the docs?). |
|
yeah you're right @lsjostro the fix was part of v1.2.4 and since the docs highlighted the example, it should be surfaced as a breaking change and not a bug fix |
arkodg
added a commit
to arkodg/gateway
that referenced
this pull request
Jan 30, 2025
adds whats left off from envoyproxy#4868 deleted the sectionName in these examples because the Service spec does not define a port `Name` Signed-off-by: Arko Dasgupta <arko@tetrate.io>
guydc
pushed a commit
that referenced
this pull request
Jan 30, 2025
adds whats left off from #4868 deleted the sectionName in these examples because the Service spec does not define a port `Name` Signed-off-by: Arko Dasgupta <arko@tetrate.io>
guydc
pushed a commit
to guydc/gateway
that referenced
this pull request
Jan 31, 2025
adds whats left off from envoyproxy#4868 deleted the sectionName in these examples because the Service spec does not define a port `Name` Signed-off-by: Arko Dasgupta <arko@tetrate.io>
guydc
pushed a commit
to guydc/gateway
that referenced
this pull request
Jan 31, 2025
adds whats left off from envoyproxy#4868 deleted the sectionName in these examples because the Service spec does not define a port `Name` Signed-off-by: Arko Dasgupta <arko@tetrate.io>
guydc
pushed a commit
to guydc/gateway
that referenced
this pull request
Jan 31, 2025
adds whats left off from envoyproxy#4868 deleted the sectionName in these examples because the Service spec does not define a port `Name` Signed-off-by: Arko Dasgupta <arko@tetrate.io>
guydc
pushed a commit
to guydc/gateway
that referenced
this pull request
Jan 31, 2025
adds whats left off from envoyproxy#4868 deleted the sectionName in these examples because the Service spec does not define a port `Name` Signed-off-by: Arko Dasgupta <arko@tetrate.io> (cherry picked from commit 45804e2) Signed-off-by: Guy Daich <guy.daich@sap.com>
guydc
pushed a commit
to guydc/gateway
that referenced
this pull request
Jan 31, 2025
adds whats left off from envoyproxy#4868 deleted the sectionName in these examples because the Service spec does not define a port `Name` Signed-off-by: Arko Dasgupta <arko@tetrate.io> (cherry picked from commit 45804e2) Signed-off-by: Guy Daich <guy.daich@sap.com>
guydc
pushed a commit
to guydc/gateway
that referenced
this pull request
Jan 31, 2025
adds whats left off from envoyproxy#4868 deleted the sectionName in these examples because the Service spec does not define a port `Name` Signed-off-by: Arko Dasgupta <arko@tetrate.io> (cherry picked from commit 45804e2) Signed-off-by: Guy Daich <guy.daich@sap.com>
guydc
added a commit
that referenced
this pull request
Jan 31, 2025
* doc: response compression (#5071) compression docs Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com> (cherry picked from commit 549fdde) Signed-off-by: Guy Daich <guy.daich@sap.com> * docs: how to specify a self-signed ca for the remote jwks host in the SP JWT settings. (#5085) * docs for jwt self-signed ca Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com> * fix gen Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com> * update docs Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com> --------- Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com> (cherry picked from commit fdc7849) Signed-off-by: Guy Daich <guy.daich@sap.com> * chore: fix gen (#5166) fix gen Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com> (cherry picked from commit 34db8af) Signed-off-by: Guy Daich <guy.daich@sap.com> * docs: add api key auth instructions (#5097) * docs: add api key auth instruction Signed-off-by: Taufik Mulyana <nothinux@gmail.com> * fix: remove unrelated links Signed-off-by: Taufik Mulyana <nothinux@gmail.com> --------- Signed-off-by: Taufik Mulyana <nothinux@gmail.com> (cherry picked from commit b5cf087) Signed-off-by: Guy Daich <guy.daich@sap.com> * add SECURITY.md (#5167) Signed-off-by: Arko Dasgupta <arko@tetrate.io> (cherry picked from commit f7a10eb) Signed-off-by: Guy Daich <guy.daich@sap.com> * chore: link SECURITY.md (#5168) Signed-off-by: Arko Dasgupta <arko@tetrate.io> (cherry picked from commit ac9026f) Signed-off-by: Guy Daich <guy.daich@sap.com> * build(deps): bump actions/stale from 9.0.0 to 9.1.0 (#5162) Bumps [actions/stale](https://github.com/actions/stale) from 9.0.0 to 9.1.0. - [Release notes](https://github.com/actions/stale/releases) - [Changelog](https://github.com/actions/stale/blob/main/CHANGELOG.md) - [Commits](actions/stale@28ca103...5bef64f) --- updated-dependencies: - dependency-name: actions/stale dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Arko Dasgupta <arkodg@users.noreply.github.com> (cherry picked from commit 57d4aa8) Signed-off-by: Guy Daich <guy.daich@sap.com> * docs: rm sectionName from some of the examples (#5173) adds whats left off from #4868 deleted the sectionName in these examples because the Service spec does not define a port `Name` Signed-off-by: Arko Dasgupta <arko@tetrate.io> (cherry picked from commit 45804e2) Signed-off-by: Guy Daich <guy.daich@sap.com> * ci(fix): osv-scanner PR mode (#5174) fix: osv-scanner PR mode Signed-off-by: shahar-h <shahar.harari@sap.com> Co-authored-by: Guy Daich <guy.daich@sap.com> (cherry picked from commit e904d3f) Signed-off-by: Guy Daich <guy.daich@sap.com> * wip: docs: add standalone in container instruction (#5172) * docs: add standalone in container instruction Signed-off-by: Denis Shatokhin <d_shatokhin@outlook.com> * docs: update headings and image tag Signed-off-by: Denis Shatokhin <d_shatokhin@outlook.com> --------- Signed-off-by: Denis Shatokhin <d_shatokhin@outlook.com> (cherry picked from commit a3448c1) Signed-off-by: Guy Daich <guy.daich@sap.com> * docs: update prerequisites files with installation and connectivity t… (#5094) * docs: update prerequisites files with installation and connectivity testing steps Signed-off-by: DeeBi9 <deepanshudb1@gmail.com> * lint Signed-off-by: DeeBi9 <deepanshudb1@gmail.com> * docs: remove the Note Signed-off-by: DeeBi9 <deepanshudb1@gmail.com> * remove redundant code Signed-off-by: DeeBi9 <deepanshudb1@gmail.com> --------- Signed-off-by: DeeBi9 <deepanshudb1@gmail.com> (cherry picked from commit 3253339) Signed-off-by: Guy Daich <guy.daich@sap.com> * [release/v1.3] fix 1.3.0-rc.1 release note (#5175) * fix 1.3.0-rc.1 release note Signed-off-by: Guy Daich <guy.daich@sap.com> * more fixes Signed-off-by: Guy Daich <guy.daich@sap.com> --------- Signed-off-by: Guy Daich <guy.daich@sap.com> (cherry picked from commit 4fba2bf) Signed-off-by: Guy Daich <guy.daich@sap.com> * fail validation if baseInterval is 0s (#5176) * fail validation if baseInterval is 0s Fixes: #5147 Signed-off-by: Arko Dasgupta <arko@tetrate.io> * more validations Signed-off-by: Arko Dasgupta <arko@tetrate.io> --------- Signed-off-by: Arko Dasgupta <arko@tetrate.io> (cherry picked from commit 4844d9a) Signed-off-by: Guy Daich <guy.daich@sap.com> * [release/1.3] release notes (#5177) Signed-off-by: Guy Daich <guy.daich@sap.com> (cherry picked from commit c2215b2) Signed-off-by: Guy Daich <guy.daich@sap.com> --------- Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com> Signed-off-by: Guy Daich <guy.daich@sap.com> Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com> Signed-off-by: Taufik Mulyana <nothinux@gmail.com> Signed-off-by: Arko Dasgupta <arko@tetrate.io> Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: shahar-h <shahar.harari@sap.com> Signed-off-by: Denis Shatokhin <d_shatokhin@outlook.com> Signed-off-by: DeeBi9 <deepanshudb1@gmail.com> Co-authored-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com> Co-authored-by: Taufik Mulyana <17433202+nothinux@users.noreply.github.com> Co-authored-by: Arko Dasgupta <arkodg@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: shahar-h <shahar.harari@sap.com> Co-authored-by: Denis Shatokhin <d_shatokhin@outlook.com> Co-authored-by: Deepanshu Bisht <113498676+DeeBi9@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update BackendTLSPolicy docs for #4784