Skip to content

Remove unnecessary uses of 'global' #1847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 11, 2025
Merged

Remove unnecessary uses of 'global' #1847

merged 1 commit into from
Apr 11, 2025

Conversation

mdickinson
Copy link
Member

A recent release of flake8 started complaining about redundant uses of global inside functions/methods, causing flake8 errors in the Traits style checks. (The relevant change is in pyflakes 3.3.0: see PyCQA/pyflakes#825.)

This PR removes those global declarations.

@mdickinson mdickinson changed the title Fix unnecessary uses of 'global', highlighted by a recent flake8 release Remove unnecessary uses of 'global', highlighted by a recent flake8 release Apr 11, 2025
@mdickinson mdickinson changed the title Remove unnecessary uses of 'global', highlighted by a recent flake8 release Remove unnecessary uses of 'global' Apr 11, 2025
flongford
flongford approved these changes Apr 11, 2025
View reviewed changes
Copy link

@flongford flongford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mdickinson mdickinson merged commit 9b91e74 into main Apr 11, 2025
32 checks passed
@mdickinson mdickinson deleted the fix/flake8-errors branch April 11, 2025 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flongford flongford flongford approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mdickinson @flongford