Implement Upsert (Stage 2.7) #290
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jack-Works
reviewed
May 11, 2025
Jack-Works
reviewed
May 11, 2025
src/intrinsics/MapPrototype.mts
Outdated
Comment on lines
134
to
135
| // a. If p.[[Key]] is not empty and SameValue(p.[[Key]], key) is true, return p.[[Value]]. | ||
| if (p.Key !== undefined && SameValueZero(p.Key, key) === Value.true) { |
There was a problem hiding this comment.
Is it SV or SVZ? Comment and the code are conflict
There was a problem hiding this comment.
It's SV, thanks for catching that.
Jack-Works
reviewed
May 15, 2025
src/intrinsics/MapPrototype.mts
Outdated
Comment on lines
157
to
159
| if (key instanceof NumberValue && Object.is(R(key), -0)) { | ||
| key = F(+0); | ||
| } |
There was a problem hiding this comment.
and you should call CanonicalizeKeyedCollectionKey you just added 👀
There was a problem hiding this comment.
Oops, thanks for catching that
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implementation passes the tests at tc39/test262#4454.