Updates regexp-match-indices feature to support 'd' flag #161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: this was tested against tc39/test262#2934 |
|
Thank you very much for this. When the tests land I will merge this 👍 |
devsnek
reviewed
Feb 23, 2021
|
tc39/test262#2934 has been merged |
9 tasks
|
Can you just update the test262 submodule so this is green? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings engine262 up-to-date with the changes for
regexp-match-indicesto use adflag to opt in to returning.indiceswhen calling.exec()(or any other function that callsRegExpBuiltinExec.