Skip to content

Conversation

AllenSH12
Copy link
Contributor

Summary

Skips mypy type check for 3.14 since they are not testing against it yet and the build in this repo is failing as a result.

More discussion in #2934

Checklist

  • I understand that this PR may be closed in case there was no previous discussion. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.

@AllenSH12
Copy link
Contributor Author

Hey @Kludex how does this look to you? Happy to make changes if needed

@Kludex
Copy link
Collaborator

Kludex commented May 19, 2025

Can we skip this on the CI instead?

@AllenSH12
Copy link
Contributor Author

Sure thing, how does that look?

@Kludex
Copy link
Collaborator

Kludex commented May 21, 2025

Thanks! :)

@Kludex Kludex merged commit bc4b937 into encode:master May 21, 2025
7 checks passed
@AllenSH12 AllenSH12 deleted the skip-314-type-check branch May 21, 2025 11:40
@AllenSH12
Copy link
Contributor Author

You're welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants