Skip to content

Add deprecated warnings to TestClient on use of timeout argument #2840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Feb 22, 2025
Merged

Add deprecated warnings to TestClient on use of timeout argument #2840

merged 9 commits into from
Feb 22, 2025

Conversation

iudeen
Copy link
Contributor

@iudeen iudeen commented Jan 4, 2025 •
edited by Kludex
Loading

Implements the solution in #1108 (comment)

Checklist

  • I understand that this PR may be closed in case there was no previous discussion. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.

Edit by @Kludex:

@iudeen iudeen marked this pull request as ready for review January 4, 2025 11:36
@iudeen iudeen requested a review from Kludex January 4, 2025 11:36
@lealre lealre mentioned this pull request Jan 4, 2025
Closed
3 tasks
@iudeen
Copy link
Contributor Author

iudeen commented Jan 4, 2025

@lealre I like the way you had created the test! I added that part of it from your PR. 😄

@Kludex Kludex changed the title Add deprecated warnings to TestClient on use of timeout argument. Add deprecated warnings to TestClient on use of timeout argument Jan 6, 2025
Kludex
Kludex approved these changes Feb 22, 2025
View reviewed changes
Copy link
Collaborator

@Kludex Kludex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. 🙏

@Kludex Kludex enabled auto-merge (squash) February 22, 2025 11:43
@Kludex Kludex merged commit 135e3af into encode:master Feb 22, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kludex Kludex Kludex approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TestClient.request does not honor timeout
2 participants
@iudeen @Kludex