Skip to content

use a pair of memory object streams instead of two queues #2829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 29, 2024
Merged

use a pair of memory object streams instead of two queues #2829

merged 1 commit into from
Dec 29, 2024

Conversation

graingert
Copy link
Contributor

@graingert graingert commented Dec 29, 2024 •
edited
Loading

Summary

Checklist

(discussed on previous PR, no tests needed as this is a plain refactor and existing tests cover it, no doc changes as this is a transparent refactor)

  • I understand that this PR may be closed in case there was no previous discussion. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.

@graingert graingert marked this pull request as ready for review December 29, 2024 11:45
Kludex
Kludex approved these changes Dec 29, 2024
View reviewed changes
Copy link
Collaborator

@Kludex Kludex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing! 🙏

@graingert graingert merged commit e16bacb into master Dec 29, 2024
5 checks passed
@graingert graingert deleted the use-memory-object-streams-instead-of-queues branch December 29, 2024 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kludex Kludex Kludex approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@graingert @Kludex