Docs: Remove SentryMiddleware from third-party list #2044
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
euri10
approved these changes
Feb 20, 2023
|
We should probably add something about Sentry. I think it was even discussed to be on the Exceptions section. I'll merge this tho, it's simple. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was going through the third-party middlewares list in the docs and came across
SentryMiddleware. As stated in the project:So I thought it may not be useful to mention it in the docs anymore.
What we could do however (not done, but I would happily do it) is to add
SentryASGIMiddlewareand link to Sentry docs: https://docs.sentry.io/platforms/python/guides/quart/configuration/integrations/asgi/ What do you think?