Skip to content

Conversation

noamkush
Copy link
Contributor

Description

Raised by another at #9495. This avoids creating the converter entirely if it is already registered.

@noamkush noamkush force-pushed the fix-django-6.0-deprecation branch from 3e7a488 to ef026ec Compare August 26, 2024 09:29
Copy link
Collaborator

@carltongibson carltongibson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sensible yes. Thanks.

@carltongibson carltongibson merged commit 5cc1028 into encode:master Aug 26, 2024
7 checks passed
Copy link
Contributor

@auvipy auvipy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we also update the tests?

@carltongibson
Copy link
Collaborator

@auvipy please do! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants