use IOCP in windows #423
use IOCP in windows #423
Conversation
There was a problem hiding this comment.
It might be not a bad idea to bring another implementation of the event loop. But in this implementation, it implicitly replaces the asyncio event loop. It may confuse the user it's generally better to keep things explicit.
So for this particular case, it would be better to create a separate module, like uvloop, so it would be possible to specify it with the --loop param running the uvicorn server.
|
I agree it. I will make changes later and resubmit. |
|
@abersheeran looks really good to me. Let's run it with @tomchristie what he thinks. |
|
Liking it, yup! |
|
So, why not merge the PR? What else do I need to modify? |
|
hey @abersheeran, I'm going to merge it today, but if you could run |
|
Actually, never mind! |
|
I am sorry that I didn't notice lint, I will use it next time. 😅 |
|
all good, thanks for the PR! |
https://docs.python.org/3/library/asyncio-policy.html#asyncio.WindowsProactorEventLoopPolicy