Skip to content

refine help message for option --proxy-headers #2653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 27, 2025

Conversation

zhangyoufu
Copy link
Contributor

Summary

This is a follow-up PR fixing document, per discussion at #1974 (comment).

ProxyHeadersMiddleware is not making use of X-Forwarded-Port header. X-Forwarded-Port header contains the listening port of the reverse proxy (usually a load balancer). X-Forwarded-Port header does not contain the client's source TCP port, thus should not be used to populate source address.

Checklist

  • I understand that this PR may be closed in case there was no previous discussion. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.

@Kludex Kludex merged commit 22dfd3f into encode:master Jun 27, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants