refine help message for option --proxy-headers #2653
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is a follow-up PR fixing document, per discussion at #1974 (comment).
ProxyHeadersMiddleware
is not making use ofX-Forwarded-Port
header.X-Forwarded-Port
header contains the listening port of the reverse proxy (usually a load balancer).X-Forwarded-Port
header does not contain the client's source TCP port, thus should not be used to populate source address.Checklist