Skip to content

fix: stop processing when requests reaches max request limit #2420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

fix: stop processing when requests reaches max request limit #2420

wants to merge 4 commits into from

Conversation

vvanglro
Copy link
Contributor

@vvanglro vvanglro commented Aug 9, 2024

Summary

#2412

Checklist

  • I understand that this PR may be closed in case there was no previous discussion. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.

@vvanglro vvanglro changed the title fix(server): stop processing when requests reaches max request limit fix: stop processing when requests reaches max request limit Aug 9, 2024
@vvanglro
Copy link
Contributor Author

vvanglro commented Aug 9, 2024

Strangely, running this newly added use case on its own succeeds every time, and occasionally fails when run with all the use cases.

@vvanglro
Copy link
Contributor Author

vvanglro commented Aug 9, 2024

Ah, I understand. Since the total number of requests is accumulated after the response is completed, it seems that it is impossible to accurately limit the maximum number of requests at present.

def on_response_complete(self) -> None:
    # Callback for pipelined HTTP requests to be started.
    self.server_state.total_requests += 1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant