Skip to content

Suppress interrupt indication on CLI and programmatic usage #2384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 20, 2024
Merged

Suppress interrupt indication on CLI and programmatic usage #2384

merged 2 commits into from
Jul 20, 2024

Conversation

maxfischer2781
Copy link
Contributor

Summary

This PR suppresses KeyboardInterrupt on CLI and programmatic usage, restoring the non-async behaviour from before #1600.

Checklist

  • I understand that this PR may be closed in case there was no previous discussion. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.

@maxfischer2781 maxfischer2781 mentioned this pull request Jul 5, 2024
Closed
3 tasks
@Kludex
Copy link
Collaborator

Kludex commented Jul 5, 2024

This makes more sense to me.

@maxfischer2781 maxfischer2781 requested a review from Kludex July 5, 2024 14:06
@Kludex Kludex enabled auto-merge (squash) July 20, 2024 07:36
@Kludex Kludex merged commit 875f6c6 into encode:master Jul 20, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kludex Kludex Kludex approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maxfischer2781 @Kludex