Skip to content

feat: clear monitor data using the HTTP API #13739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Nov 25, 2024
Merged

feat: clear monitor data using the HTTP API #13739

merged 5 commits into from
Nov 25, 2024

Conversation

zhongwencool
Copy link
Contributor

@zhongwencool zhongwencool commented Sep 1, 2024 •
edited by zmstone
Loading

Feature: #10246

Need dashboard support delete /monitor API

Release version: v/e5.8.4

Summary

PR Checklist

Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:

  • Added tests for the changes
  • Added property-based tests for code which performs user input validation
  • Changed lines covered in coverage report
  • Change log has been added to changes/(ce|ee)/(feat|perf|fix|breaking)-<PR-id>.en.md files
  • For internal contributor: there is a jira ticket to track this change
  • Created PR to emqx-docs if documentation update is required, or link to a follow-up jira ticket
  • Schema changes are backward compatible

Checklist for CI (.github/workflows) changes

  • If changed package build workflow, pass this action (manual trigger)
  • Change log has been added to changes/ dir for user-facing artifacts update

@zhongwencool zhongwencool marked this pull request as ready for review September 2, 2024 01:54
@zhongwencool zhongwencool force-pushed the clear-monitor-api branch 2 times, most recently from e3682a3 to ee98352 Compare September 2, 2024 02:35
@zmstone
Copy link
Member

zmstone commented Nov 24, 2024

@zhongwencool thank you for the PR, could you rebase to the branch release-584?

@zhongwencool
Copy link
Contributor Author

@zhongwencool thank you for the PR, could you rebase to the branch release-584?

DONE.

@zmstone zmstone changed the base branch from release-58 to release-584 November 25, 2024 09:50
zmstone
zmstone reviewed Nov 25, 2024
View reviewed changes
@zhongwencool zhongwencool merged commit 716be0a into emqx:release-584 Nov 25, 2024
199 checks passed
@zhongwencool zhongwencool deleted the clear-monitor-api branch November 25, 2024 23:39
@emqxqa
Copy link

emqxqa commented Dec 9, 2024

TestExecution

@BrewTestBot BrewTestBot mentioned this pull request Dec 27, 2024
Merged
@AndriyKhymera
Copy link

AndriyKhymera commented Feb 24, 2025 •
edited
Loading

Hey @zmstone, @zhongwencool
I can see that you've merged the changes and they are part of the 5.8.4 release. But for some reason, this doesn't work for me.

I'm doing:

  1. DELETE on ../api/v5/metrics. Getting 204.
  2. GET ../api/v5/metrics. Getting 200 with a list of metrics. Same on the dashboard ../dashboard/metrics/

I'm using the emqx:latest docker image. From the docker inspect I can see that image was created at "2025-01-07T05:32:24Z".

I assume that all of the metrics should be cleaned up if I use the endpoint. For example "messages.publish" or "messages.dropped", right?
Are there some configuration or known issues where this might not work? Is there a workaround I can use to clean up the metrics?

I would appreciate the help! Thanks!

@zmstone
Copy link
Member

zmstone commented Feb 25, 2025

HI @AndriyKhymera
The path should be /monitor
Try send DELETE .../api/v5/monitor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zmstone zmstone zmstone left review comments

@keynslug keynslug Awaiting requested review from keynslug

@JimMoen JimMoen Awaiting requested review from JimMoen

@lafirest lafirest Awaiting requested review from lafirest

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zhongwencool @zmstone @emqxqa @AndriyKhymera