feat(trace): expose max trace file size limit as config option #15556
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release-60 #15556 +/- ##
==============================================
+ Coverage 81.66% 84.43% +2.77%
==============================================
Files 1127 1114 -13
Lines 82581 78686 -3895
==============================================
- Hits 67438 66439 -999
+ Misses 15143 12247 -2896 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
thalesmg
approved these changes
Jul 24, 2025
| ?assertMatch( | ||
| FS when FS =< MaxSize andalso FS > MaxSize div 2, | ||
| FileSize, | ||
| {max_file_size, MaxSize} |
There was a problem hiding this comment.
Nit: maybe add FileSize too to have more context.
There was a problem hiding this comment.
It should be part of {actual, ...} tuple if match fails.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes EMQX-14467.
Release version: 6.0.0
Summary
This PR exposes trace file size limit as a configuration option, with 512 MiB preserved as a default.
Now that it's possible for the user to set much lower limits, risk of hitting this limit is increased. Currently, because tracing is implemented on top of
loggersubsystem components, there's no direct feedback: active trace does not know that the limit is hit. Instead, messages like these are printed to stdout / stderr:This is obviously poor user experience, improvements to be made in followup PRs. Proposals are outlined here.
PR Checklist
changes/ee/(feat|perf|fix|breaking)-<PR-id>.en.mdfiles