Skip to content

feat(ai_completion): add custom base url for providers #15201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 13, 2025
Merged

feat(ai_completion): add custom base url for providers #15201

merged 2 commits into from
May 13, 2025

Conversation

savonarola
Copy link
Contributor

@savonarola savonarola commented May 13, 2025 •
edited
Loading

Fixes EMQX-14254

Release version: 5.10

Summary

Also slightly improved tests: HTTP client now makes actual requests (although to a mock HTTP service).

PR Checklist

  • For internal contributor: there is a jira ticket to track this change
  • The changes are covered with new or existing tests
  • Change log for changes visible by users has been added to changes/ee/(feat|perf|fix|breaking)-<PR-id>.en.md files
  • Schema changes are backward compatible or intentionally breaking (describe the changes and the reasoning in the summary)

@savonarola savonarola force-pushed the 250513-add-custom-hosts-for-ai-profiles branch 2 times, most recently from 5fe8478 to e8dafa0 Compare May 13, 2025 14:47
@savonarola savonarola marked this pull request as ready for review May 13, 2025 14:48
@savonarola savonarola requested a review from a team as a code owner May 13, 2025 14:48
@savonarola savonarola force-pushed the 250513-add-custom-hosts-for-ai-profiles branch 2 times, most recently from 0434c69 to d341524 Compare May 13, 2025 16:54
@savonarola savonarola force-pushed the 250513-add-custom-hosts-for-ai-profiles branch from d341524 to dd77b00 Compare May 13, 2025 18:10
thalesmg
thalesmg previously approved these changes May 13, 2025
View reviewed changes
@codecov-commenter
Copy link

codecov-commenter commented May 13, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 96.92308% with 2 lines in your changes missing coverage. Please review.

Project coverage is 82.86%. Comparing base (88bff93) to head (258f0fd).
Report is 23 commits behind head on release-510.

Files with missing lines Patch % Lines
apps/emqx_utils/src/emqx_utils_uri.erl 96.42% 2 Missing ⚠️
Additional details and impacted files 
@@               Coverage Diff               @@
##           release-510   #15201      +/-   ##
===============================================
+ Coverage        82.73%   82.86%   +0.13%     
===============================================
  Files             1084     1084              
  Lines            77169    77221      +52     
===============================================
+ Hits             63845    63989     +144     
+ Misses           13324    13232      -92

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@savonarola savonarola merged commit 15dd336 into emqx:release-510 May 13, 2025
163 checks passed
@savonarola savonarola deleted the 250513-add-custom-hosts-for-ai-profiles branch May 13, 2025 21:45
@emqxqa
Copy link

emqxqa commented May 17, 2025

TestExecution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thalesmg thalesmg thalesmg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@savonarola @codecov-commenter @emqxqa @thalesmg