Skip to content

feat(mt): add APIs to manage explicit namespaces #14884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Mar 19, 2025
Merged

feat(mt): add APIs to manage explicit namespaces #14884

merged 12 commits into from
Mar 19, 2025

Conversation

thalesmg
Copy link
Contributor

@thalesmg thalesmg commented Mar 17, 2025 •
edited
Loading

Fixes https://emqx.atlassian.net/browse/EMQX-13821

Fixes https://emqx.atlassian.net/browse/EMQX-13822

Release version: e5.9.0

Summary

PR Checklist

  • Added tests for the changes
  • Change log has been added to changes/(ce|ee)/(feat|perf|fix|breaking)-<PR-id>.en.md files
  • For internal contributor: there is a jira ticket to track this change
  • Schema changes are backward compatible (unreleased feature)

@thalesmg thalesmg force-pushed the 20250313-r59-mt-config-explicit branch from 1d457c6 to 73b129d Compare March 17, 2025 20:02
@thalesmg thalesmg force-pushed the 20250313-r59-mt-config-explicit branch from 73b129d to b569d89 Compare March 17, 2025 20:39
@thalesmg thalesmg force-pushed the 20250313-r59-mt-config-explicit branch from b569d89 to b909a3d Compare March 17, 2025 20:50
@thalesmg thalesmg marked this pull request as ready for review March 18, 2025 12:10
@thalesmg thalesmg requested a review from a team as a code owner March 18, 2025 12:10
zmstone
zmstone reviewed Mar 18, 2025
View reviewed changes
Copy link
Member

@zmstone zmstone left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking, there is perhaps no need for explicit APIs, if we add a config like:

emqx_mt {
    managed_namespaces = true | false
}

And deny access in authentication callback in emqx_mt_hookcb module if this config is set to true but tns does not exist.

@thalesmg thalesmg force-pushed the 20250313-r59-mt-config-explicit branch 2 times, most recently from b93ee93 to 597d800 Compare March 18, 2025 19:56
@thalesmg thalesmg force-pushed the 20250313-r59-mt-config-explicit branch from 597d800 to 5095e58 Compare March 18, 2025 19:59
@thalesmg thalesmg force-pushed the 20250313-r59-mt-config-explicit branch from 5095e58 to 554d7d1 Compare March 18, 2025 20:15
thalesmg
thalesmg commented Mar 19, 2025
View reviewed changes
@thalesmg thalesmg marked this pull request as draft March 19, 2025 09:05
@thalesmg thalesmg marked this pull request as ready for review March 19, 2025 12:18
zmstone
zmstone reviewed Mar 19, 2025
View reviewed changes
apps/emqx_mt/src/emqx_mt_limiter.erl
%% Note: we may safely delete the limiter groups here: when clients attempt to consume
%% from the now dangling limiters, `emqx_limiter_client' will log the error but don't
%% do any limiting when it fails to fetch the missing limiter group configuration.
%% The user may choose to later kick all clients from this namespace.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe a separate task: there should be an API to kick (async) all sessions under a namespace.

And deleting managed NS should immediately trigger such kicks.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://emqx.atlassian.net/browse/EMQX-14034

@thalesmg @zmstone
docs: change descriptions
32f4ea4 
Co-authored-by: zmstone <zmstone@gmail.com>
@thalesmg thalesmg merged commit 6c32718 into emqx:release-59 Mar 19, 2025
139 checks passed
@thalesmg thalesmg deleted the 20250313-r59-mt-config-explicit branch March 19, 2025 17:32
@emqxqa
Copy link

emqxqa commented Mar 31, 2025

TestExecution

@emqxqa
Copy link

emqxqa commented Mar 31, 2025

TestExecution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zmstone zmstone zmstone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thalesmg @emqxqa @zmstone