Skip to content

Conversation

zmstone
Copy link
Member

@zmstone zmstone commented Dec 6, 2024

Fixes EMQX-13611
Release version: v/e5.8.4

Summary

Define usage function before called.
Also change to use $0 in help prints instead of relying on the variable $REL_NAME.

See individual commit diffs for clarity.

PR Checklist

Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:

  • Added tests for the changes
  • Added property-based tests for code which performs user input validation
  • Changed lines covered in coverage report
  • Change log has been added to changes/(ce|ee)/(feat|perf|fix|breaking)-<PR-id>.en.md files
  • For internal contributor: there is a jira ticket to track this change
  • Created PR to emqx-docs if documentation update is required, or link to a follow-up jira ticket
  • Schema changes are backward compatible

Checklist for CI (.github/workflows) changes

  • If changed package build workflow, pass this action (manual trigger)
  • Change log has been added to changes/ dir for user-facing artifacts update

@zmstone zmstone requested a review from a team as a code owner December 6, 2024 11:55
@zmstone zmstone mentioned this pull request Dec 6, 2024
9 tasks
@zmstone zmstone force-pushed the 241206-fix-emqx-usage-print branch from 807f05e to 85b9382 Compare December 6, 2024 11:58
Copy link
Contributor

@keynslug keynslug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@zmstone zmstone merged commit df512e2 into emqx:release-58 Dec 6, 2024
196 checks passed
@zmstone zmstone deleted the 241206-fix-emqx-usage-print branch December 6, 2024 17:47
@emqxqa
Copy link

emqxqa commented Dec 9, 2024

TestExecution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants