Skip to content

fix(log): add no-drag region to select input on log page #1942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 11, 2025
Merged

Conversation

ysfscream
Copy link
Member

@ysfscream ysfscream commented Jun 10, 2025

PR Checklist

If you have any questions, you can refer to the Contributing Guide

What is the current behavior?

The el-select dropdown in the log page triggers window dragging when clicked, preventing normal selection of log levels.

image

Issue Number

Example: #123

What is the new behavior?

Fixed el-select to only respond to click operations. Users can now normally select log levels without accidentally dragging the window.

Does this PR introduce a breaking change?

  • Yes
  • No

Specific Instructions

  • Pure CSS fix: Added -webkit-app-region: no-drag to el-select component
  • Only affects log page dropdown selector
  • Test that dropdown clicks don't trigger window dragging

Other information

Fix Type: UI/UX bug fix
Scope: Log page only
Breaking Changes: None

@ysfscream ysfscream added this to the v1.12.0 milestone Jun 10, 2025
@ysfscream ysfscream requested review from Red-Asuka and Copilot June 10, 2025 03:28
@ysfscream ysfscream self-assigned this Jun 10, 2025
@ysfscream ysfscream added enhancement New feature or request fix Fix bug or issues desktop MQTTX Desktop labels Jun 10, 2025
@ysfscream ysfscream added this to MQTTX Jun 10, 2025
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR prevents accidental window dragging when interacting with the log level dropdown by disabling the drag region on the select component.

  • Adds a CSS rule to disable -webkit-app-region for the <el-select> element on the log page.

@ysfscream ysfscream moved this to In Progress in MQTTX Jun 10, 2025
@Red-Asuka Red-Asuka merged commit f6493fa into main Jun 11, 2025
4 checks passed
@Red-Asuka Red-Asuka deleted the ysf/desktop branch June 11, 2025 02:23
@github-project-automation github-project-automation bot moved this from In Progress to Done in MQTTX Jun 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop MQTTX Desktop enhancement New feature or request fix Fix bug or issues
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants