feat(copilot): gemini 2.5 thinking mode support #1949
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for Gemini 2.5 thinking variants by registering new model identifiers, updating the agent logic to detect and configure “thinking” modes for Google models, adjusting tests, and bumping the Google SDK dependency.
- Register new Gemini 2.5 models (including thinking and flash variants) in
AImodelsOptions - Extend
AIAgent.processModelto detect and handle Google thinking models - Update unit tests to include the new Gemini 2.5 options and bump
@ai-sdk/googleversion
Reviewed Changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tests/unit/utils/ai/copilot.spec.ts | Added assertions for gemini-2.5-pro and gemini-2.5-pro-thinking, updated provider test model |
| src/utils/ai/copilot.ts | Registered new Gemini 2.5 model variants in the AI models options |
| src/utils/ai/AIAgent.ts | Implemented isGoogleThinking detection and adjusted request payload for thinking models |
| package.json | Bumped @ai-sdk/google dependency to ^1.2.12 |
Comments suppressed due to low confidence (1)
src/utils/ai/AIAgent.ts:173
- Add unit tests for the
isGoogleThinkingbranch inprocessModelto verify that it correctly trims the-thinkingsuffix and setsisGoogleThinkingto true for models likegemini-2.5-pro-thinking.
const isGoogleThinking = model.includes('gemini') && model.endsWith('-thinking')
Comment on lines
+86
to
88
| expect(google?.children.map((c) => c.value)).to.include('gemini-2.5-pro') | ||
| expect(google?.children.map((c) => c.value)).to.include('gemini-2.5-pro-thinking') | ||
| expect(google?.children.map((c) => c.value)).to.include('gemini-1.5-pro') |
There was a problem hiding this comment.
[nitpick] Consider extracting google?.children.map(c => c.value) into a single variable to avoid repeated mapping and improve readability.
Suggested change
| expect(google?.children.map((c) => c.value)).to.include('gemini-2.5-pro') | |
| expect(google?.children.map((c) => c.value)).to.include('gemini-2.5-pro-thinking') | |
| expect(google?.children.map((c) => c.value)).to.include('gemini-1.5-pro') | |
| const googleChildrenValues = google?.children.map((c) => c.value) | |
| expect(googleChildrenValues).to.include('gemini-2.5-pro') | |
| expect(googleChildrenValues).to.include('gemini-2.5-pro-thinking') | |
| expect(googleChildrenValues).to.include('gemini-1.5-pro') |
Copilot uses AI. Check for mistakes.
Red-Asuka
approved these changes
Jun 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
If you have any questions, you can refer to the Contributing Guide
What is the current behavior?
Please describe the current behavior and link to a relevant issue.
Issue Number
Example: #123
What is the new behavior?
Please describe the new behavior or provide screenshots.
Does this PR introduce a breaking change?
Specific Instructions
Are there any specific instructions or things that should be known prior to review?
Other information